New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support mysql with rollup #1923
feat: support mysql with rollup #1923
Conversation
src/test/resources/net/sf/jsqlparser/statement/select/oracle-tests/merge04.sql
Outdated
Show resolved
Hide resolved
src/test/java/net/sf/jsqlparser/statement/select/SelectTest.java
Outdated
Show resolved
Hide resolved
this.mysqlWithRollup = mysqlWithRollup; | ||
} | ||
|
||
public GroupByElement withMysqlWithRollup(boolean mysqlWithRollup) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, that previously those "withMethods" have been implemented, but nobody ever gave me a reason why the "setMethod" should not return the object directly.
Feel free to avoid that redundant "withMethod" and return the object when calling the "set" method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my knowledge, in functional programming, it is generally referred to as with. The true meaning is to create a new object and return it without modifying the object itself, but here, with modifies the object, so set and with are indeed duplicates at this point.
I have fixed the Test related issues not linked to this PR directly. Please re-sync, sorry for the extra step. |
Thank you, I have revised it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Thank you for working on this! |
try to closed #1907