Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add additional CREATE VIEW modifiers #1964

Merged
merged 3 commits into from Feb 13, 2024
Merged

feat: add additional CREATE VIEW modifiers #1964

merged 3 commits into from Feb 13, 2024

Conversation

davidjgoss
Copy link
Contributor

This PR adds

  • SECURE as a new modifier on the CREATE VIEW syntax
  • VOLATILE as an alias for the existing TEMPORARY modifier

Fixes #1959

@manticore-projects
Copy link
Contributor

manticore-projects commented Feb 12, 2024 •
edited

Greetings!

Thank you for working on this. Unfortunately the tests fail. Please fix it and then I would merge it asap.
Since you introduced new tokens, you will need to Update the Keyword whitelist as explained here: https://manticore-projects.com/JSQLParser/contribution.html#manage-reserved-keywords

@manticore-projects
Copy link
Contributor

Nice and clean! Thank you for your effort and contribution.

@manticore-projects manticore-projects merged commit 67e2204 into JSQLParser:master Feb 13, 2024
2 of 3 checks passed
@davidjgoss davidjgoss deleted the feat/create-view-modifiers branch February 14, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] additional modifiers for CREATE VIEW
2 participants
@davidjgoss @manticore-projects