Add missing java.sql require #1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now the JavaDoc fails? gradle publishToMavenLocaland make this run? |
|
Maven also throws errors now [ERROR] Errors: [ERROR] DeclareStatementTest.testDeclareTable:98 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57 [ERROR] DeclareStatementTest.testDeclareType:43 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57 [ERROR] DeclareStatementTest.testDeclareTypeList:72 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57 [ERROR] DeclareStatementTest.testDeclareTypeWithDefault:56 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57 [ERROR] AlterTest.testAlterOnlyIssue928:577 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57 [ERROR] AlterTest.testAlterTableCheckConstraint:280 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57 [ERROR] AlterTest.testAlterTableColumnCommentIssue984:645 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57 [ERROR] AlterTest.testAlterTableTableCommentIssue984:632 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57 [ERROR] AlterSequenceTest.testCreateSequence_withIncrement:33 » InaccessibleObject Unable to make field private int java.lang.Enum.hash accessible: module java.base does not "opens java.lang" to unnamed module @67545b57 [INFO] [ERROR] Tests run: 3129, Failures: 0, Errors: 9, Skipped: 20 [INFO] [WARNING] Corrupted channel by directly writing to native stream in forked JVM 1. See FAQ web page and the dump file /home/are/Documents/src/JSQLFormatter/JSQLParser/target/surefire-reports/2024-04-30T12-16-58_973-jvmRun1.dumpstream |
|
@manticore-projects I checked out the commit before i did anything. the maven tests still fail. They are just broken on newer java versions. Same deal with |
|
No worries, I got that fixed in the latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1998