-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: column names in INSERT statement should be simple, not FQN. #589
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,41 +62,55 @@ public void setColumnName(String string) { | |
|
||
@Override | ||
public String getFullyQualifiedName() { | ||
return getName(false); | ||
return getFullyQualifiedName(false); | ||
} | ||
|
||
/** | ||
* Get name with out without using aliases. | ||
* | ||
* @param aliases | ||
* Get FQN. | ||
* @param aliases - use aliases. | ||
* @return | ||
*/ | ||
public String getName(boolean aliases) { | ||
public String getFullyQualifiedName(boolean aliases) { | ||
StringBuilder fqn = new StringBuilder(); | ||
|
||
if (table != null) { | ||
if (table.getAlias() != null && aliases) { | ||
if (aliases && table.getAlias() != null) { | ||
fqn.append(table.getAlias().getName()); | ||
} else { | ||
fqn.append(table.getFullyQualifiedName()); | ||
} | ||
} | ||
if (fqn.length() > 0) { | ||
fqn.append('.'); | ||
if (fqn.length() > 0) { | ||
fqn.append('.'); | ||
} | ||
} | ||
if (columnName != null) { | ||
fqn.append(columnName); | ||
fqn.append(getName()); | ||
} | ||
|
||
return fqn.toString(); | ||
} | ||
|
||
/** | ||
* Get name. | ||
* @return | ||
*/ | ||
public String getName() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe update doc with “@return the simple name of the column. “ |
||
StringBuilder name = new StringBuilder(); | ||
|
||
if (columnName != null) { | ||
name.append(columnName); | ||
} | ||
|
||
return name.toString(); | ||
} | ||
|
||
@Override | ||
public void accept(ExpressionVisitor expressionVisitor) { | ||
expressionVisitor.visit(this); | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return getName(true); | ||
return getFullyQualifiedName(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this would force us to do a major version bump right?