Searchbar across all bib files instead each having its own #1549

chriba · 2016-07-05T10:33:48Z

Implemented #825.
The SearchBar is now in the top Toolbar instead of each Tab having its own (always at the right).
On Tab change the Tab gets updated.
The Autocomplete is bound to the current Tab (maybe extend this one in another PR?).
The old global Search (opening all findings in a new Window) is gone, do we really need it?

Change in CHANGELOG.md described
Tests created for changes
Screenshots added (for bigger UI changes)

boceckts · 2016-07-05T11:29:58Z

src/main/java/net/sf/jabref/gui/JabRefFrame.java

+            BasePanel currentBasePanel = getCurrentBasePanel();
+            if (currentBasePanel == null) {
+                globalSearchBar.setVisible(false);
+                globalSearchBar.setAutoCompleter(null);
                return;
            }


This only disables the global search bar when the last database will be closed. But the search bar will be shown when one is starting jabref with no open database.

good catch, I'll fix it quickly

boceckts · 2016-07-05T12:55:07Z

Good work 👍

teertinker · 2016-07-06T05:25:22Z

I am really happy that you are working on this. Is it correct, that the "global search" window will be abandoned? I have no idea whether it is causing any conflict with the current implementation of the search mechanism, but I am one of those who is using it rather extensively.

There are two scenarios, where a global search is useful:

Often I create a separate bib file for a project (e.g. a journal article), where I put all related papers. Some of them are of interest just for this project and are not supposed to be part of my database core (e.g. newspaper articles). Hence, I often use search queries that include results of the core and project related file
I have a bib file for papers which I use in a certain context, but that haven't been read thoroughly yet. Some of them will eventually be moved to the 'core database'. Also in this case I use a global search to find results within both bib-files.

Both scenarios could be managed by creating groups, and if global search gets abandoned, I will certainly do. However, I like the tab based style of several bib files very much, because I don't have the feeling that my project related articles get lost in my huge database with thousands of entries

koppor · 2016-07-07T09:00:52Z

👍 for keeping the global search window. Please readd it. @bartsch-dev There are many JabRef users having more than 10 bib files. They do not want to click through all 10 files for each search.

matthiasgeiger · 2016-07-07T09:14:06Z

Another aspect: What happens if the horiztonal space is not enough to display all icons and the search bar? Will the searchbar be displayed beneath the icon bar?

oscargus · 2016-07-08T10:16:24Z

Based on another issue the minimum width of the window is already around 1000 pixels (depending on look-an-feel, OS, etc), so it is crucial that it will fold.

But it indeed looks promising!

chriba · 2016-07-13T13:17:38Z

if the window is too small for the toolbar it will now wrap between the normal buttons and the searchbar.

The search result Dialog will now remember its location; the global search has a shortcut (ctrl+shift+f, #573); enter in the result dialog will select the entry in the BasePanel (#617); the Reuslt window is cloasable with ctrl+w if fdocused (#573 (comment)); and the result dialog won't stay at top anymore if the MainFrame is focused and they are on top of each other.

boceckts · 2016-07-15T10:53:16Z

src/main/java/net/sf/jabref/gui/keyboard/KeyBinding.java

    REPLACE_STRING("Replace string", Localization.lang("Replace string"), "ctrl R"),
    RESOLVE_DUPLICATE_BIBTEX_KEYS("Resolve duplicate BibTeX keys", Localization.lang("Resolve duplicate BibTeX keys"), "ctrl shift D"),
    SAVE_ALL("Save all", Localization.lang("Save all"), "ctrl alt S"),
    SAVE_DATABASE("Save database", Localization.lang("Save database"), "ctrl S"),
-    SAVE_DATABASE_AS(
-            "Save database as ...", Localization.lang("Save database as..."), "ctrl shift S"),
+    SAVE_DATABASE_AS("Save database as ...", Localization.lang("Save database as..."), "ctrl shift S"),


Please do not change the format of lines you didn't modify.

boceckts · 2016-07-15T10:54:02Z

Please resolve conflicts.

boceckts · 2016-07-15T10:59:27Z

src/main/java/net/sf/jabref/gui/search/GlobalSearchBar.java

@@ -90,7 +93,7 @@ public GlobalSearchBar() {

        openCurrentResultsInDialog.setToolTipText(Localization.lang("Show search results in a window"));
        openCurrentResultsInDialog.addActionListener(ae -> {


Please rename the variable "ae", same goes for the other listeners named "l"

boceckts · 2016-07-15T11:17:43Z

enter in the result dialog will select the entry in the BasePanel

I have two databases open and search for a keyword
I open the global search and it finds my result entries from both databases
I press enter on an entry and it focuses the correct tab but it always selects the first entry in this tab

EDIT: It does focus the correct entry if I am already in the right tab, but if it has to focus a different tab it always selects the first entry.

Did I missunderstand the sentence or is this a bug?

boceckts · 2016-07-15T11:27:29Z

src/main/java/net/sf/jabref/gui/search/GlobalSearchBar.java

+    private final JTextFieldWithUnfocusedText searchField = new JTextFieldWithUnfocusedText(Localization.lang("Search") + "...");
+    private final JButton clearSearchButton = new JButton(IconTheme.JabRefIcon.CLOSE.getSmallIcon());
+    private final JButton openCurrentResultsInDialog = new JButton(IconTheme.JabRefIcon.OPEN_IN_NEW_WINDOW.getSmallIcon());
+    private final JButton globalSearch = new JButton(Localization.lang("Search globally"));


Can you find an icon for this as well? Toolbars shouldn't include buttons with large strings.

chriba · 2016-07-15T11:53:06Z

Should be fixed now!

boceckts · 2016-07-15T12:10:13Z

src/main/java/net/sf/jabref/gui/search/GlobalSearchBar.java

        toolBar.add(new HelpAction(HelpFiles.SEARCH));
-
+        toolBar.addSeparator();
+        toolBar.add(currentResults);


This will cause the toolbar to jump around when typing and clearing a search query. To fit the searchbar in the first row I need to use full screen mode and than there is no space to the right at all. So once I start typing the result text will be displayed and the searchbar jumps to the second row, when I clear the search it jumps back to the 1st row since the text is invisible. In my opinion the text with the number of found results should be somewhere else.

I've set the preffered size of the lable to 100px which contains the standard Found X entries-Message.

koppor · 2016-07-18T08:42:42Z

Is it possible to work on the global search in this PR, too?

The shortcut ctrl+shift+f should focus the search field if it is empty (instead of doing a globally searching the empty string)
ESC in the global search should focus the search field. Currently, the focus just stays where it was
The global search popup should show the bib file name

koppor · 2016-09-08T12:38:24Z

CHANGELOG.md

+- The search result Window will now show which entry belongs to which bib file
+- The search result Window will now remember its location
+- The search result Window won't stay on top anymore if the main Window is focused and will be present in the taskbar
+- The User can jump from the searchbar to the maintabel with `ctrl + enter`


fix typos user, maintable

Keyboard shortcuts should be rendered consistenly without space before and after +

koppor · 2016-09-08T20:43:21Z

Searchbar disappers at certain occaisions. Please try to increase/decrease the width of JabRef and you'll see that at some point, it disappears:

It also happens during the search if "no results found" is appended. Then, the searchbar disapears after having nothing found:

chriba · 2016-09-10T14:58:20Z

fixed

koppor · 2016-09-11T09:25:33Z

Tested with bce1bf5 - not fixed:

* master: Remove obsolete wrapper task Added error dialog when setting invalid main file directory (#1921) Add filteringCharset = 'UTF-8' (#1945) Include https://github.com/grimes2 Searchbar across all bib files instead each having its own (#1549) Some OO/LO cleanups (#1927) Update link Removed external dependency in logic (#1934)

* master: Remove obsolete wrapper task Added error dialog when setting invalid main file directory (JabRef#1921) Add filteringCharset = 'UTF-8' (JabRef#1945) Include https://github.com/grimes2 Searchbar across all bib files instead each having its own (JabRef#1549) Some OO/LO cleanups (JabRef#1927) Update link Removed external dependency in logic (JabRef#1934)

boceckts added stupro labels Jul 5, 2016

boceckts reviewed Jul 5, 2016
View reviewed changes

boceckts added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed stupro-ready-for-internal-review labels Jul 5, 2016

koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 7, 2016

boceckts added the stupro-ready-for-internal-review label Jul 15, 2016

boceckts reviewed Jul 15, 2016
View reviewed changes

chriba added 7 commits September 8, 2016 13:48

fix foxus

f85a729

fix focus

686edfd

fix traversal after abort search

d44aab3

The User can jump from the searchbar to the maintabel with

5f1b356

fix trailing spaces

46d74e4

fix localization again

409a043

fix rebase issues

cd718de

koppor reviewed Sep 8, 2016
View reviewed changes

chriba added 3 commits September 8, 2016 14:57

remove empty line

b9a620f

fix typos

d395395

add missing getter

3c17a09

fix disappearing of the searchbar in 2nd row at small height

bce1bf5

chriba added 2 commits September 11, 2016 11:36

refactor layout

d8f7a81

Merge remote-tracking branch 'jabref/master' into globalSearch

c21ab8e

koppor merged commit 543c176 into JabRef:master Sep 11, 2016

chriba deleted the globalSearch branch September 11, 2016 10:25

koppor mentioned this pull request Sep 11, 2016

Search bar across different bib files #825

Closed

chriba mentioned this pull request Sep 12, 2016

Fix when editing a bibEntry field the searchbar would be focused #1961

Merged

stefan-kolb added a commit that referenced this pull request Sep 14, 2016

Fix missing language keys #1549

560a545

stefan-kolb added a commit that referenced this pull request Sep 14, 2016

Fix reason for missing key #1549

05e7f0d

zesaro pushed a commit to zesaro/jabref that referenced this pull request Nov 22, 2016

Searchbar across all bib files instead each having its own (JabRef#1549)

b17be55

zesaro pushed a commit to zesaro/jabref that referenced this pull request Nov 22, 2016

Fix missing language keys JabRef#1549

0647ed7

zesaro pushed a commit to zesaro/jabref that referenced this pull request Nov 22, 2016

Fix reason for missing key JabRef#1549

f7b5e54

koppor mentioned this pull request Jun 5, 2018

Global search not available #4096

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Searchbar across all bib files instead each having its own #1549

Searchbar across all bib files instead each having its own #1549

chriba commented Jul 5, 2016

boceckts Jul 5, 2016

chriba Jul 5, 2016

boceckts commented Jul 5, 2016

teertinker commented Jul 6, 2016

koppor commented Jul 7, 2016

matthiasgeiger commented Jul 7, 2016

oscargus commented Jul 8, 2016

chriba commented Jul 13, 2016

boceckts Jul 15, 2016

boceckts commented Jul 15, 2016

boceckts Jul 15, 2016

boceckts commented Jul 15, 2016 •

edited

boceckts Jul 15, 2016

chriba commented Jul 15, 2016

boceckts Jul 15, 2016

chriba Jul 16, 2016

koppor commented Jul 18, 2016 •

edited

koppor Sep 8, 2016

koppor Sep 8, 2016

chriba Sep 8, 2016

koppor commented Sep 8, 2016

chriba commented Sep 10, 2016

koppor commented Sep 11, 2016

		@@ -90,7 +93,7 @@ public GlobalSearchBar() {

		openCurrentResultsInDialog.setToolTipText(Localization.lang("Show search results in a window"));
		openCurrentResultsInDialog.addActionListener(ae -> {

Searchbar across all bib files instead each having its own #1549

Searchbar across all bib files instead each having its own #1549

Conversation

chriba commented Jul 5, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boceckts commented Jul 5, 2016

teertinker commented Jul 6, 2016

koppor commented Jul 7, 2016

matthiasgeiger commented Jul 7, 2016

oscargus commented Jul 8, 2016

chriba commented Jul 13, 2016

Choose a reason for hiding this comment

boceckts commented Jul 15, 2016

Choose a reason for hiding this comment

boceckts commented Jul 15, 2016 • edited

Choose a reason for hiding this comment

chriba commented Jul 15, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koppor commented Jul 18, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koppor commented Sep 8, 2016

chriba commented Sep 10, 2016

koppor commented Sep 11, 2016

boceckts commented Jul 15, 2016 •

edited

koppor commented Jul 18, 2016 •

edited