Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New file link" opens wrong folder in FileDialog #1609

Closed
matthiasgeiger opened this issue Jul 21, 2016 · 6 comments
Closed

"New file link" opens wrong folder in FileDialog #1609

matthiasgeiger opened this issue Jul 21, 2016 · 6 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs status: waiting-for-feedback The submitter or other users need to provide more information about the issue ui

Comments

@matthiasgeiger
Copy link
Member

matthiasgeiger commented Jul 21, 2016

JabRef version 3.5 and current 3.6dev on Windows 10

Steps to reproduce:

  1. Define a "main file directory" for a DB or globally
  2. Try to create a "new file link" by hitting the "+" in next to the file field
  3. The file dialog does not open the "main file directory" but its parent folder

Reported by @bkleine in the discourse forum

@matthiasgeiger matthiasgeiger added bug Confirmed bugs or reports that are very likely to be bugs ui labels Jul 21, 2016
@Siedlerchr
Copy link
Member

I will try to work on this in the next days. See #1336

Siedlerchr added a commit to Siedlerchr/jabref that referenced this issue Jul 30, 2016
Fix for JabRef#1609
TODO: Investigate BrowseAction usage in FileListEntryEditor
@bernhard-kleine
Copy link

On a first glance it does not open the intended directory but requires a further click on the "browse" button to open the link. This is a different behaviour as before. Actually I prefer when the link is opened. I have installed: JabRef_windows-x64_3_6dev--snapshot--2016-08-10--master--8342956.exe

@Siedlerchr Siedlerchr reopened this Aug 10, 2016
@Siedlerchr
Copy link
Member

Siedlerchr commented Aug 10, 2016

I rechecked the code and you are partly right.

  1. When you click the "+" sign on an entry, then the open dialog should be directly shown (no further click necessary. (will fix this)
    2.) However, when you do Quality-> Lookup full text document, then the open dialog is only shown after you click on Browse. OK-> (I did not touch that behaviour)

Edit:// I described both cases here, because it's the same code and dialog that is used in both cases

@Siedlerchr
Copy link
Member

Please test again with the version from here:
http://builds.jabref.org/fix1609/

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Aug 11, 2016
@bernhard-kleine
Copy link

I tested it with that version. It works. However I experienced repeatingly file save issues: The first time an entry was cut before I was fully saved, interestingly the same entry was completely saved just after that faulty saved one. The next time, there were three entries not completely saved, however the completely entries were just behind. (Detected by editing the file with Notepad++). The error is in the save process and is not detected by Jabref itself, only by running biber on this file.

@Siedlerchr
Copy link
Member

@bernhard-kleine Thanks for your feedback. Would you please open a new issues for this and provide some steps for reproducing? As many details as possible. That helps us to track the error/faulty save process.

ayanai1 pushed a commit to ayanai1/jabref that referenced this issue Sep 5, 2016
Refactored Open and Save dialogs
Introduced FileExtensions enum for FileDialog Filter
Updated BrowseAction to use new dialogs
Fix JabRef#1324 
Fix JabRef#1609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs status: waiting-for-feedback The submitter or other users need to provide more information about the issue ui
Projects
None yet
Development

No branches or pull requests

3 participants