Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollbar invisible in Preferences -> BibTex Key Pattern #4287

Closed
Siedlerchr opened this issue Aug 23, 2018 · 9 comments
Closed

Scrollbar invisible in Preferences -> BibTex Key Pattern #4287

Siedlerchr opened this issue Aug 23, 2018 · 9 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. hacktoberfest Hacktoberfest tag. See https://hacktoberfest.digitalocean.com/faq/ for details. preferences ui
Projects
JavaFX UI Rework Bugs

Comments

@Siedlerchr
Copy link
Member

Siedlerchr commented Aug 23, 2018 •
edited

@tobiasdiez

grafik

And you should set the colspan of the gridpane which includes the pane of the biblatex key panel to 2
@tobiasdiez tobiasdiez added the bug Confirmed bugs or reports that are very likely to be bugs label Aug 23, 2018
@tobiasdiez tobiasdiez added this to ToDo in JavaFX UI Rework via automation Aug 23, 2018
@tobiasdiez tobiasdiez added this to Needs triage in Bugs via automation Aug 23, 2018
@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Aug 23, 2018
@Siedlerchr Siedlerchr mentioned this issue Aug 23, 2018
Closed
@Siedlerchr
Copy link
Member Author

Siedlerchr commented Aug 24, 2018 •
edited

Edit// I think we need to add css properties for the scroll pane, e.g.scroll-pane > .corner
Description of the CSS properties: https://blog.ngopal.com.np/2012/07/11/customize-scrollbar-via-css/

@tobiasdiez tobiasdiez moved this from Needs triage to High priority in Bugs Aug 31, 2018
@tobiasdiez tobiasdiez moved this from High priority to Low priority in Bugs Aug 31, 2018
@omkarnix
Copy link

As a first timer, can I pick this issue if nobody is working on it?

@Siedlerchr
Copy link
Member Author

@omkarnix Sure, go ahead!

@omkarnix
Copy link

Sure. I am working on it. Thanks for the encouragement!

@Siedlerchr Siedlerchr added the hacktoberfest Hacktoberfest tag. See https://hacktoberfest.digitalocean.com/faq/ for details. label Oct 2, 2018
@omkarnix
Copy link

omkarnix commented Oct 13, 2018 •
edited

@Siedlerchr Sorry for late response. I tried to fix this by following the given tutorial but looks like need some more time to learn Java FX its CSS, scrollbar. But I think I will be able to contribute better at back-end side in fixing issues or writing tests. Will search for issues and see if I can help there.
Also, please let me know if you think there is any back-end or devops issue in which I could contribute.
Thanks!

@omkarnix
Copy link

@Siedlerchr
Also, can we use some open source tool like SonarCube to find code coverage and start adding the tests suggested by the tool?

@Siedlerchr
Copy link
Member Author

@omkarnix Well, just look at the list of open issues. While many of them are related to the GUI transformation from swing to JavaFx, there are also some non GUI issues.
One important issue is the check for multipe instances of JabRf: #4023

We have code coverage reports enabled here as well, but the statistics are irrelevant as the most important things are already covered (e.g. logic and model) .

@tobiasdiez
Copy link
Member

@omkarnix most of the issues tagged with code quality, fetcher or import/export are mostly concerned with the backend:
https://github.com/JabRef/jabref/issues?q=is%3Aissue+is%3Aopen+label%3Acode-quality
https://github.com/JabRef/jabref/issues?q=is%3Aissue+is%3Aopen+label%3Afetcher
https://github.com/JabRef/jabref/issues?q=is%3Aissue+is%3Aopen+label%3Aimport
export / save

Tests are important as well, especially for the model/logic as @Siedlerchr said. Feel free to add tests for uncovered parts, but please don't write test methods for trivial code (such as getter & setter).

@omkarnix
Copy link

@tobiasdiez Sure. Thanks. I would certainly like to contribute on tests.

@pavlapp pavlapp mentioned this issue Oct 16, 2018
Closed
pavlapp added a commit to pavlapp/jabref that referenced this issue Oct 22, 2018
@pavlapp
Scrollbar invisible in Preferences -> BibTex Key Pattern (JabRef#4287)[…
0715b64 
…JabRef#4287]

* fix invisible scrollbar in preferences
* divided gridpane to multiple columns
pavlapp added a commit to pavlapp/jabref that referenced this issue Oct 22, 2018
@pavlapp
Scrollbar invisible in Preferences -> BibTex Key Pattern (JabRef#4287)
2c1b56f 
* fix invisible scrollbar in preferences
* divided gridpane to multiple columns
JavaFX UI Rework automation moved this from ToDo to Completed Oct 24, 2018
Bugs automation moved this from Low priority to Closed Oct 24, 2018
Siedlerchr added a commit that referenced this issue Oct 27, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into ooPanel
3a7ef14 
* upstream/master: (30 commits)
  Update README.md (#4419)
  Fix generate bibtex key overwrite warning dialog (#4418)
  Fix group hit counter when adding entries (#4413)
  Update README.md
  fix java.nio.file.FileSystemNotFoundException and reorganize code (#4416)
  fixed an issue where corresponding groups are sometimes not highlighted when clicking on entries (#4404)
  Add a few journal abbreviations (#4412)
  Fix display of radio buttons (#4411)
  Update issue templates
  Delete ISSUE_TEMPLATE.md
  Update issue templates
  Integrate mrdlib redesign (#4361)
  fix "save" button in preference dialog not response (#4406)
  show dialog before creating entry (#4405)
  Scrollbar invisible in Preferences -> BibTex Key Pattern (#4287) (#4398)
  Updates (#4402)
  Fixes for all mods exporter tests (#4396)
  Fix EntryType dialog not closed after generate button (#4390)
  Make rank image narrower (#4395)
  Fix showing multiple icons for one menu entry - fixes #4384 (#4392)
  ...
Siedlerchr added a commit that referenced this issue Oct 29, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into docbookfive
4f21871 
* upstream/master: (54 commits)
  Update README.md (#4419)
  Fix generate bibtex key overwrite warning dialog (#4418)
  Fix group hit counter when adding entries (#4413)
  Update README.md
  fix java.nio.file.FileSystemNotFoundException and reorganize code (#4416)
  fixed an issue where corresponding groups are sometimes not highlighted when clicking on entries (#4404)
  Add a few journal abbreviations (#4412)
  Fix display of radio buttons (#4411)
  Update issue templates
  Delete ISSUE_TEMPLATE.md
  Update issue templates
  Integrate mrdlib redesign (#4361)
  fix "save" button in preference dialog not response (#4406)
  show dialog before creating entry (#4405)
  Scrollbar invisible in Preferences -> BibTex Key Pattern (#4287) (#4398)
  Updates (#4402)
  Fixes for all mods exporter tests (#4396)
  Fix EntryType dialog not closed after generate button (#4390)
  Make rank image narrower (#4395)
  Fix showing multiple icons for one menu entry - fixes #4384 (#4392)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. hacktoberfest Hacktoberfest tag. See https://hacktoberfest.digitalocean.com/faq/ for details. preferences ui
Projects
Bugs
Archived in project
Bugs
  
Done
JavaFX UI Rework
  
Completed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Siedlerchr @tobiasdiez @omkarnix