Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing file extension for downloaed file #5816

Closed
1 task
Krzmbrzl opened this issue Jan 6, 2020 · 5 comments · Fixed by #5841
Closed
1 task

Missing file extension for downloaed file #5816

Krzmbrzl opened this issue Jan 6, 2020 · 5 comments · Fixed by #5841
Assignees
@tobiasdiez
Labels
bug Confirmed bugs or reports that are very likely to be bugs external files
Projects
Bugs
Milestone
v5.0

Comments

@Krzmbrzl
Copy link

Krzmbrzl commented Jan 6, 2020

JabRef version JabRef 5.0.0-dev--2019-10-25----681d6aa6f
Linux 5.0.0-37-generic amd64
Java 12.0.2

Steps to reproduce the behavior:

  1. Import en entry into the database (via JabFox)
  2. Right click on the full-text URL and select Download file
  3. The downloaded file doesn't have a file extension

Expected behaviour: The file should have the file extension .pdf
Actual behaviour: The file ends with a dot and no extemsion (e.g. test. instead of test.pdf)
@tobiasdiez
Copy link
Member

I had this problem too with some links but cannot remember which. Do you have a concrete example where this issue appears?

@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs external files labels Jan 6, 2020
@tobiasdiez tobiasdiez added this to Needs triage in Bugs via automation Jan 6, 2020
@tobiasdiez tobiasdiez added this to the v5.0 milestone Jan 6, 2020
@tobiasdiez tobiasdiez moved this from Needs triage to Normal priority in Bugs Jan 6, 2020
@Krzmbrzl
Copy link
Author

Krzmbrzl commented Jan 6, 2020 •
edited
Loading

Yes - most recently it happened to me with https://pubs.acs.org/doi/abs/10.1021/jacs.9b04902

@Krzmbrzl
Copy link
Author

Krzmbrzl commented Jan 6, 2020

If it helps, I could go through my library and give you other links that produced this behavior for me ☝️

@tobiasdiez tobiasdiez self-assigned this Jan 17, 2020
tobiasdiez added a commit that referenced this issue Jan 18, 2020
@tobiasdiez
Fix missing file extension for downloaded files. Fixes #5816 by falli…
c8ba83c 
…ng back to PDF as default file type.
@tobiasdiez tobiasdiez mentioned this issue Jan 18, 2020
Merged
5 tasks
Bugs automation moved this from Normal priority to Closed Jan 18, 2020
Siedlerchr pushed a commit that referenced this issue Jan 18, 2020
@tobiasdiez @Siedlerchr
Fix missing file extension for downloaded files. Fixes #5816 by falli…
2612e22 
…ng back to PDF as default file type. (#5841)
@Siedlerchr
Copy link
Member

Thanks to @tobiasdiez this should be fixed now in the latest master

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

Siedlerchr added a commit that referenced this issue Jan 18, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into customizeEntrydlg
f5ba88e 
# By Oliver Kopp (4) and others
# Via github actions (3) and Christoph (1)
* upstream/master:
  Fix missing file extension for downloaded files. Fixes #5816 by falling back to PDF as default file type. (#5841)
  The PDF has a title - try another publication without an available PDF (#5840)
  Fix BibTeX VM for IEEE (and some micro other fixes) (#5839)
  Squashed 'src/main/resources/csl-styles/' changes from 19c89f5..9c0f5c6
  Improve serialization to fix #4877 (#5838)
  Build on all branches
  update unirest (#5836)
  Squashed 'src/main/resources/csl-locales/' changes from a3e8843f75..41da445acc
  Squashed 'src/main/resources/csl-styles/' changes from bb01625..19c89f5
  Build binaries only when src/main changes (#5806)
  Bump archunit-junit5-api from 0.12.0 to 0.13.0 (#5827)
  Bump classgraph from 4.8.59 to 4.8.60 (#5828)
  Bump mariadb-java-client from 2.5.2 to 2.5.3 (#5829)
  Update jdk to build 30
  Improve change detection (#5824)

# Conflicts:
#	src/main/resources/l10n/JabRef_en.properties
@Krzmbrzl
Copy link
Author

I currently don't have access to my computer running JabRef. Will try as soon as I get back to it. Remind me to report back :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiasdiez tobiasdiez

Labels
bug Confirmed bugs or reports that are very likely to be bugs external files
Projects
Bugs
Archived in project
Bugs
  
Done
Milestone
v5.0
Development

Successfully merging a pull request may close this issue.

Fix missing file extension for downloaded files. JabRef/jabref
3 participants
@Siedlerchr @tobiasdiez @Krzmbrzl