Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build binaries only when src/main changes #5806

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

koppor
Copy link
Member

@koppor koppor commented Jan 2, 2020

IMHO we need new binaries on builds.jabref.org only if src/main/** changes. Not if we work on tests.

@koppor koppor force-pushed the installer-only-when-src-main-changes branch from 243936b to c97b0dd Compare January 2, 2020 05:12
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 2, 2020
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that builds for changes to tests alone are not really necessary. However, PRs with only tests are very rare. Not sure if this optimization is really necessary.

.github/workflows/deployment.yml Outdated Show resolved Hide resolved
.github/workflows/deployment.yml Outdated Show resolved Hide resolved
@koppor
Copy link
Member Author

koppor commented Jan 8, 2020

I'm using the "ignoring paths" pattern now. Just want to save resources. 🎉

@koppor koppor merged commit 58709e7 into master Jan 15, 2020
@koppor koppor deleted the installer-only-when-src-main-changes branch January 15, 2020 00:20
Siedlerchr added a commit that referenced this pull request Jan 18, 2020
# By Oliver Kopp (4) and others
# Via github actions (3) and Christoph (1)
* upstream/master:
  Fix missing file extension for downloaded files. Fixes #5816 by falling back to PDF as default file type. (#5841)
  The PDF has a title - try another publication without an available PDF (#5840)
  Fix BibTeX VM for IEEE (and some micro other fixes) (#5839)
  Squashed 'src/main/resources/csl-styles/' changes from 19c89f5..9c0f5c6
  Improve serialization to fix #4877 (#5838)
  Build on all branches
  update unirest (#5836)
  Squashed 'src/main/resources/csl-locales/' changes from a3e8843f75..41da445acc
  Squashed 'src/main/resources/csl-styles/' changes from bb01625..19c89f5
  Build binaries only when src/main changes (#5806)
  Bump archunit-junit5-api from 0.12.0 to 0.13.0 (#5827)
  Bump classgraph from 4.8.59 to 4.8.60 (#5828)
  Bump mariadb-java-client from 2.5.2 to 2.5.3 (#5829)
  Update jdk to build 30
  Improve change detection (#5824)

# Conflicts:
#	src/main/resources/l10n/JabRef_en.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants