Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace "SearchAll" in web search by "Search Selected" #10611

Merged
merged 10 commits into from
Nov 9, 2023
Merged

replace "SearchAll" in web search by "Search Selected" #10611

merged 10 commits into from
Nov 9, 2023

Conversation

lisongxuan
Copy link
Contributor

Closes #10556

  • Implemented "Search Selected".
    image

  • Enabled configuring the catalogs to be searched.
    image

  • Updated menu and other corresponding UI
    image

  • Updated corresponding tests

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@lisongxuan
replace "SearchAll" in web search by "Search Selected"
c72e3bd 
see:JabRef#10556
Implemented "Search Selected".
Enabled configuring the catalogs to be searched.
Updated menu and other corresponding UI
Updated corresponding tests
@lisongxuan lisongxuan marked this pull request as draft November 1, 2023 09:13
@lisongxuan lisongxuan marked this pull request as ready for review November 1, 2023 10:17
@lisongxuan
Copy link
Contributor Author

No clue about what happened to fetcher tests:( any help is appreciated!

Siedlerchr
Siedlerchr requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks already good, just a few code style things

koppor
koppor previously requested changes Nov 2, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.fxml Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcher.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcher.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcher.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcher.java Outdated Show resolved Hide resolved
src/test/java/org/jabref/gui/slr/ManageStudyDefinitionViewModelTest.java Show resolved Hide resolved
src/test/java/org/jabref/logic/crawler/StudyCatalogToFetcherConverterTest.java Outdated Show resolved Hide resolved
src/test/java/org/jabref/logic/importer/WebFetchersTest.java Show resolved Hide resolved
src/test/java/org/jabref/logic/importer/fetcher/CompositeSearchBasedFetcherTest.java Outdated Show resolved Hide resolved
Siedlerchr and others added 3 commits November 9, 2023 21:03
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into Issue#10556-Search-…
c95d0e8 
…Selected

* upstream/main:
  Update to JavaFX 21.01 (JabRef#10627)
  Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549)
  fix tests
  Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625)
  Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1
  Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2
  Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0
  Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0
  Change linter (JabRef#10614)
@Siedlerchr
refactoring
8af920d
@calixtus
Update WebSearchPaneViewModel.java
3e5dda6 
Remove whitespace
@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 9, 2023
Merged via the queue into JabRef:main with commit c1cb2d7 Nov 9, 2023
17 of 18 checks passed
Siedlerchr added a commit to xuanan20020/jabref that referenced this pull request Nov 10, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-348
373dec5 
* upstream/main: (24 commits)
  Add support for scite.ai (JabRef#10617)
  Update tests.yml (JabRef#10631)
  replace "SearchAll" in web search by "Search Selected" (JabRef#10611)
  Use System preference for light dark theme (JabRef#10593)
  Fix NPE in lookup identifer
  Add minimum requirements to CHANGELOG.md (JabRef#10628)
  Update to JavaFX 21.01 (JabRef#10627)
  Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549)
  fix tests
  Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625)
  Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1
  Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2
  Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0
  Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0
  Change linter (JabRef#10614)
  change codecov (JabRef#10616)
  Add entry based on ISSN number JabRef#10124 (JabRef#10178)
  Enable journal information fetcher directly in popup (JabRef#10598)
  Make generate button wider (JabRef#10588)
  make openRewrite stable again
  ...

# Conflicts:
#	CHANGELOG.md
#	src/main/resources/l10n/JabRef_en.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus approved these changes

@koppor koppor Awaiting requested review from koppor

Assignees
No one assigned
Labels
fetcher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web Search: "SearchAll" should be replaced by "Search Selected"
5 participants
@lisongxuan @Siedlerchr @koppor @calixtus @ThiloteE