Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Search: "SearchAll" should be replaced by "Search Selected" #10556

Closed
5 tasks
koppor opened this issue Oct 23, 2023 · 2 comments · Fixed by #10611
Closed
5 tasks

Web Search: "SearchAll" should be replaced by "Search Selected" #10556

koppor opened this issue Oct 23, 2023 · 2 comments · Fixed by #10611
Assignees
@lisongxuan
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@koppor
Copy link
Member

koppor commented Oct 23, 2023

Background

Current of the web search:

current-web-search

In the SLR feature, we offer a selection mode of selecting libraries to the SLR feature. This feature should be re-used in this form.

slr

The SLR can be started at

image

Tasks

  • Implement "Search Selected". Inspiration by the "SearchAll" functionality.
  • Enable configuring the catalogs to be searched. Should be done in Preferences / Web Search (refs https://github.com/JabRef/jabref-issue-melting-pot/issues/140). Heading Catalogues used for "Search Selected".
    new
  • In the menu: Rename "SearchAll" to "Search Selected" (think, this is done by deleting SearchAll classes and references and inserting the reference to the Search Selected funtionality)
  • Position "Search Selected" at the beginning of the drop down
  • Ensure that in the UI, "catalogs" is used as term. Not "libraries", "web resources", ...
@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Oct 23, 2023
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Oct 23, 2023
@lisongxuan
Copy link
Contributor

Hello, I am interested in working on this issue. Could you assign it to me? Thank you.

@ThiloteE ThiloteE moved this from Free to take to Reserved in Candidates for University Projects Oct 24, 2023
@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Oct 24, 2023
@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 24, 2023
@github-actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

lisongxuan added a commit to lisongxuan/jabref that referenced this issue Nov 1, 2023
@lisongxuan
replace "SearchAll" in web search by "Search Selected"
778d495 
see:JabRef#10556
Implemented "Search Selected".
Enabled configuring the catalogs to be searched.
Updated menu and other corresponding UI
Updated corresponding tests
lisongxuan added a commit to lisongxuan/jabref that referenced this issue Nov 1, 2023
@lisongxuan
replace "SearchAll" in web search by "Search Selected"
c72e3bd 
see:JabRef#10556
Implemented "Search Selected".
Enabled configuring the catalogs to be searched.
Updated menu and other corresponding UI
Updated corresponding tests
@lisongxuan lisongxuan mentioned this issue Nov 1, 2023
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 9, 2023
@lisongxuan @Siedlerchr @calixtus
replace "SearchAll" in web search by "Search Selected" (#10611)
c1cb2d7 
* replace "SearchAll" in web search by "Search Selected"

see:#10556
Implemented "Search Selected".
Enabled configuring the catalogs to be searched.
Updated menu and other corresponding UI
Updated corresponding tests

* Fix Markdown and Checkstyle

* Fix Checkstyle

* Fix code style

* Fix code styles

* refactoring

* Update WebSearchPaneViewModel.java

Remove whitespace

---------

Co-authored-by: Siedlerchr <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lisongxuan lisongxuan

Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Candidates for University Projects
Archived in project
Good First Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace "SearchAll" in web search by "Search Selected" lisongxuan/jabref
3 participants
@koppor @lisongxuan @ThiloteE