Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed default status of 'Automatically open folder of attached files' #10748

Merged
merged 9 commits into from
Jan 9, 2024
Merged

Changed default status of 'Automatically open folder of attached files' #10748

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3611dfa
Changed default status of 'Automatically open folder of attached files'
DumitruDruta Jan 5, 2024
4325d84
Merge branch 'main' into fix-for-issue56
DumitruDruta Jan 5, 2024
551f6a0
Changed the original default value
DumitruDruta Jan 5, 2024
f0911bb
Updated CHANGELOG.md
DumitruDruta Jan 6, 2024
bd1e9a7
Update CHANGELOG.md
Siedlerchr Jan 6, 2024
45c1a99
Merge branch 'main' into fix-for-issue56
DumitruDruta Jan 9, 2024
41cbd86
Made changes OS specific
DumitruDruta Jan 9, 2024
2f15bbc
Whitespace issues fixed
DumitruDruta Jan 9, 2024
4b3e5e0
Update CHANGELOG.md
koppor Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/gui/preferences/external/ExternalTabViewModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public ExternalTabViewModel(DialogService dialogService, PreferencesService pref
@Override
public void setValues() {
eMailReferenceSubjectProperty.setValue(initialExternalApplicationPreferences.getEmailSubject());
autoOpenAttachedFoldersProperty.setValue(initialExternalApplicationPreferences.shouldAutoOpenEmailAttachmentsFolder());
autoOpenAttachedFoldersProperty.setValue(!initialExternalApplicationPreferences.shouldAutoOpenEmailAttachmentsFolder());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not make sense. Whenever the user checks the checkbox, it will not be opened?

You just need to adjust it in the JabRefPreferences itself, change defaults value for the property

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback. I have taken it into consideration and made some changes, which I already pushed. I hope the new solution will be better.


pushToApplicationsListProperty.setValue(
FXCollections.observableArrayList(PushToApplications.getAllApplications(dialogService, preferences)));
Expand Down
Loading