Changed default status of 'Automatically open folder of attached files' #10748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Jan 5, 2024
| @@ -90,7 +90,7 @@ public ExternalTabViewModel(DialogService dialogService, PreferencesService pref | |||
| @Override | |||
| public void setValues() { | |||
| eMailReferenceSubjectProperty.setValue(initialExternalApplicationPreferences.getEmailSubject()); | |||
| autoOpenAttachedFoldersProperty.setValue(initialExternalApplicationPreferences.shouldAutoOpenEmailAttachmentsFolder()); | |||
| autoOpenAttachedFoldersProperty.setValue(!initialExternalApplicationPreferences.shouldAutoOpenEmailAttachmentsFolder()); | |||
There was a problem hiding this comment.
this does not make sense. Whenever the user checks the checkbox, it will not be opened?
You just need to adjust it in the JabRefPreferences itself, change defaults value for the property
There was a problem hiding this comment.
Thank you for your feedback. I have taken it into consideration and made some changes, which I already pushed. I hope the new solution will be better.
|
looks good, now please add a changelog entry to the "Changed section" |
|
Changelog has been updated. |
Siedlerchr
previously approved these changes
Jan 6, 2024
Siedlerchr
previously approved these changes
Jan 6, 2024
Siedlerchr
added
the
status: ready-for-review
|
Thank you for the effort. Unfortunately, this PR DOES NOT solve the issue.
The issue is about introducing an Operating-System specific default!! |
koppor
requested changes
Jan 8, 2024
| @@ -737,7 +737,7 @@ private JabRefPreferences() { | |||
| defaults.put(KEY_GEN_ALWAYS_ADD_LETTER, Boolean.FALSE); | |||
| defaults.put(EMAIL_SUBJECT, Localization.lang("References")); | |||
| defaults.put(KINDLE_EMAIL, ""); | |||
| defaults.put(OPEN_FOLDERS_OF_ATTACHED_FILES, Boolean.FALSE); | |||
| defaults.put(OPEN_FOLDERS_OF_ATTACHED_FILES, Boolean.TRUE); | |||
There was a problem hiding this comment.
Please make this OS-specific.
If Windows: TRUE - else FALSE
koppor
removed
the
status: ready-for-review
koppor
approved these changes
Jan 9, 2024
|
@DumitruDruta Thank you for the quick follow-up. We will merge as soon as the checks pass. |
Siedlerchr
added a commit
that referenced
this pull request
Jan 12, 2024
* upstream/main: (25 commits) Remove remainging "testLogging" (#10769) Reuse JUnit 5.7's @DisabledIfEnvironmentVariable (#10768) Refactored LibraryTab (#10732) Fix annotation (#10766) Add initial .git-blame-ignore-revs (#10765) Streamline test output (#10762) Fix NPE when opening and re-opening a library (#10763) Changed default status of 'Automatically open folder of attached files' (#10748) Implement test cases for search (#10193) Add cites field to bib entries for citation relation (#10752) Ignore submodule changes (for normal devs) (#10754) Fix line endings Bump lycheeverse/lychee-action from 1.8.0 to 1.9.0 (#10760) Bump appleboy/ssh-action from 1.0.2 to 1.0.3 (#10761) Bump org.apache.lucene:lucene-core from 9.9.0 to 9.9.1 (#10759) Bump org.openrewrite.rewrite from 6.5.4 to 6.6.3 (#10758) Bump org.glassfish.jersey.containers:jersey-container-grizzly2-http (#10755) Bump org.jsoup:jsoup from 1.16.2 to 1.17.2 (#10756) Bump org.mockito:mockito-core from 5.7.0 to 5.8.0 (#10757) Remove abstract ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the default value of the "Automatically open folders of attached files" checkbox to checked. This has been done by negating the boolean value that controls this checkbox and the feature behind it. "Closes koppor#56"
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)