Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated pdf indexed files from Lucene index #11293

Merged
merged 1 commit into from
May 13, 2024

Conversation

LoayGhreeb
Copy link
Collaborator

Addressed an issue where outdated pdf files were not being removed from the Lucene index.

The duplicate checker checks for the modification time of the pdf but doesn't remove it from the index if it is outdated.

This causes a lot of duplication in the index every time a library opens, the pdf will be added to the index again.
This also led to incorrect search results when using old keywords.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added this pull request to the merge queue May 13, 2024
Merged via the queue into JabRef:main with commit 708b4c7 May 13, 2024
21 checks passed
@LoayGhreeb LoayGhreeb deleted the fix-pdf-indexing branch May 13, 2024 19:09
Siedlerchr added a commit that referenced this pull request May 19, 2024
* upstream/main:
  Update latex citations status in JavaFx thread (#11302)
  Remove EnglishStemAnalyzer and use EnglishAnalyzer (#11301)
  Fix comment (#11299)
  Try gradle build speedup (#11300)
  Remove obsolete step (#11295)
  Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (#11290)
  Remove outdated pdf indexed files from Lucene index (#11293)
  Bump src/main/resources/csl-styles from `5338902` to `434df0a` (#11292)
  Bump org.mockito:mockito-core from 5.11.0 to 5.12.0 (#11291)
  Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 (#11289)
  Bump com.dlsc.gemsfx:gemsfx from 2.12.0 to 2.16.0 (#11287)
  Bump org.openrewrite.recipe:rewrite-recipe-bom from 2.9.0 to 2.11.0 (#11288)
  Introduce formatter to remove word-enclosing braces (#11253)
  Try parallel tests (#9797)
  Store preview divider pos in entry editor (#11285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants