Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when path is no valid directory #2527

Merged
merged 1 commit into from
Feb 8, 2017
Merged

Fix error when path is no valid directory #2527

merged 1 commit into from
Feb 8, 2017

Conversation

Siedlerchr
Copy link
Member

Fixes the exception Folder parameter must be a valid folder
Internal fix, 4.0.0 only
When no working directory is set and last used path was an actual file, File Dialog could not be opened.
Fixes #2522

Fixes the exception Folder parameter must be a valid folder
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 7, 2017
@stefan-kolb
Copy link
Member

LGTM, but what is the normal behavior for system dialogs? If I select a file ijnstead of a directory, is it possible and selects the parent folder or is the select button inactive?

@Siedlerchr
Copy link
Member Author

@stefan-kolb My fix has only impact when opening the dialog, that it opens in a directory without an exception . It has no impact on the selection of files etc.

Parent does not mean parent directory, but the directory itself (the parent of the file):
Example: Your last selected file was X:\abc\defg.pdf
When you try to set the initalDirectory to this complete path (including filename), it gives an exception, because it is obviously no a folder (directory). Therefore, the fix now sets the dir to X:\abc (which is the parent of X:\abc\defg.pdf

@stefan-kolb
Copy link
Member

Ah **** sorry for that! Yeah I know, i was aware of that.

@stefan-kolb stefan-kolb merged commit 4e3b48f into master Feb 8, 2017
@stefan-kolb stefan-kolb deleted the fileDlgFix branch February 8, 2017 16:40
Siedlerchr added a commit that referenced this pull request Feb 8, 2017
* upstream/master:
  Fix error when path is no valid directory (#2527)
  French localization: translation of a string
  French menu: localization
  Highlight groups that match any/all of the entries selected in the main table. (#2515)
  Fix % sign cleanup (#2521)
  Revert "Fix repeated escaping of % sign" (#2520)
  Fix repeated escaping of % sign (#2519)
  fix for #2482 deadlock on PDF import (#2517)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to save a database
2 participants