Optimize data fetching

[Ali96kz]

Optimize fetching data from database

[Siedlerchr]

Thanks for your contribution. Could you please explain the changes a bit?

[Ali96kz]

@Siedlerchr Instead of getting one entry from database. I get all entries with one query and then parse them.

[tobiasdiez]

Thanks a lot for your PR. That's a very reasonable and good improvement. The code looks also very good. Can you please add a test for the new method similar to the following; then we can merge.

jabref/src/test/java/org/jabref/logic/shared/DBMSProcessorTest.java

Lines 197 to 215 in e7780ed

	@ParameterizedTest
	@MethodSource("getTestingDatabaseSystems")
	void testGetSharedIDVersionMapping(DBMSType dbmsType, DBMSConnection dbmsConnection, DBMSProcessor dbmsProcessor) throws OfflineLockException, SQLException {
	dbmsProcessor.setupSharedDatabase();
	BibEntry firstEntry = getBibEntryExample();
	BibEntry secondEntry = getBibEntryExample();
	dbmsProcessor.insertEntry(firstEntry);
	dbmsProcessor.insertEntry(secondEntry);
	dbmsProcessor.updateEntry(secondEntry);
	Map<Integer, Integer> expectedIDVersionMap = new HashMap<>();
	expectedIDVersionMap.put(firstEntry.getSharedBibEntryData().getSharedID(), 1);
	expectedIDVersionMap.put(secondEntry.getSharedBibEntryData().getSharedID(), 2);
	Map<Integer, Integer> actualIDVersionMap = dbmsProcessor.getSharedIDVersionMapping();
	assertEquals(expectedIDVersionMap, actualIDVersionMap);
	}

[tobiasdiez]

So this method should also replace getSharedEntryList below, right?

[tobiasdiez]

The original formatting looked right to me.

[tobiasdiez]

There are still two unresolved comments. It would be nice if you could have a look at them and then we can merge. Thanks

[tobiasdiez]

@Ali96kz Since this PR is almost ready for merge, it would be nice if you could fix the two small remaining issues.

[Ali96kz]

Fixed.

[Siedlerchr]

Thanks for the update! LGTM now!

[tobiasdiez]

For the follow-up. I slightly refactored the code and merged it now.

[schniepp]

Wow. That made a huge difference!
For my DB with ≈3,800 entries, the load time went from 36 seconds to ≈3 seconds. My client is now on the same GBit network on which my fast DB server sits. I have yet to try from home with lower bandwidth, where the load time for the same DB was ≈210 seconds.