Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE when opening a non existing file from the recent files menu #5338

Merged
merged 5 commits into from
Sep 21, 2019
Merged

Fix NPE when opening a non existing file from the recent files menu #5338

merged 5 commits into from
Sep 21, 2019

Commits on Sep 20, 2019

  1. Fix NPE when opening a non existing file from the recent files menu 

    dialogService object was null, because the FileHistoryMenu class is initialized before the ctor of JabRef frame creates the dialog service object
    @Siedlerchr
    Siedlerchr committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    8af0503 View commit details
    Browse the repository at this point in the history

  2. fix checkstyle

    @Siedlerchr
    Siedlerchr committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    644b1e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2019

  1. Revert "fix checkstyle" 

    This reverts commit 644b1e0.
    @Siedlerchr
    Siedlerchr committed Sep 21, 2019
    Configuration menu
    Copy the full SHA
    3cb2790 View commit details
    Browse the repository at this point in the history

  2. initialize FileHistoryMenu in ctor

    @Siedlerchr
    Siedlerchr committed Sep 21, 2019
    Configuration menu
    Copy the full SHA
    c1103e3 View commit details
    Browse the repository at this point in the history

  3. pass opendatabase action instead of JabRef Frame

    @Siedlerchr
    Siedlerchr committed Sep 21, 2019
    Configuration menu
    Copy the full SHA
    004006c View commit details
    Browse the repository at this point in the history