Add Info plist to mac resources

[Siedlerchr]

Hopefully fixes #5935

Can't test it as I don't own a mac.

Based on https://hg.openjdk.java.net/jdk/jdk/file/tip/src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/resources/Runtime-Info.plist.template

Added the key NSSupportsAutomaticGraphicsSwitching with a value of true.

• Change in CHANGELOG.md described (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for bigger UI changes)
• Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

[stefan-kolb]

@LinusDietz Could you test this for us? 😺

[tobiasdiez]

The file name needs to be exactly the same one as in the upstream jdk, so in this case Runtime-Info.plist I guess

[Siedlerchr]

@halirutan Could you test again? I renamed the file, hopefully it gets replaced

[Siedlerchr]

I downloaded the newly built ones and it still does not use the custom one.
Although it should: https://bugs.openjdk.java.net/browse/JDK-8233175

[halirutan]

@Siedlerchr This bugreport is exactly what I was looking at as well, and I also find it odd that it doesn't work. You test if the solution works by downloading the mac tar.gz and looking at the Info.plist. I guess there's no way around debugging the Gradle task.

[tobiasdiez]

According to
https://github.com/openjdk/jdk/blob/a94b4fc695ad29653b87ff1ec572babcda4cca5c/src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacAppImageBuilder.java#L71-L74
the file should end on template. It should work now. Note that the info.plist in the Contents/runtime folder is changed, there is also one directly in Contents.

[Siedlerchr]

I'm out of ideas. It seems like those plist file is always overwritten again or regenerated.

[halirutan]

@Siedlerchr Stupid question: When jpackage is run through Gradle, is it called twice? Once for building the image and one for building the installer? What I want to point at is that we set the resource-folder in the installerOptions but shouldn't this be an option for jpackageImage?

[Siedlerchr]

@halirutan Interesting thought, we have proesses for copying over the jabfox related extension stuff,

if (OperatingSystem.current().isLinux()) {
    tasks.jpackageImage.doLast {
        copy {
            from("${projectDir}/buildres/linux") {
                include "native-messaging-host/**", "jabrefHost.py"
            }
            into "$buildDir/distribution/JabRef/lib"
        }
    }
}

Feel free to add a task for mac (You should be able to directly push to this branch)

[tobiasdiez]

Good observation @halirutan. I tried to include the resource directory now already for the image creation.

[Siedlerchr]

Seems like it didn't work. No idea why it doesnt work

[Siedlerchr]

Trying again with the jdk14 release version

[Siedlerchr]

Refs beryx/badass-jlink-plugin#132

[Siedlerchr]

Okay, I got it to work. At least the Runtime-Info.plist is correct now. The Info.plist under Contents also