-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SaveOrderConfigPanel #7935
Conversation
Good! While you are at it, can you please take a look at https://discourse.jabref.org/t/sort-order-for-export/2598/12 |
I noticed, that when i change the number of criterias and save it, JabRef complains about the file being saved by another program. Could have something to do with it? I can take a deeper look into this, but I'm somewhat careful, because I don't want this PR to explode beyond dealing with the visual representation. Let's see where this is going. |
DevCall decision:
|
Fixes koppor#510 |
A messy job, that was on my ToDo list for some time now.
I gave the SaveOrderConfigPanel an overhaul to make it a little bit more generic and to be able to work with more than three SortCriteria.
Before:
![grafik](https://user-images.githubusercontent.com/50491877/126831024-ef1ef346-42ff-431e-88a3-79c2cafdadd1.png)
After:
![grafik](https://user-images.githubusercontent.com/50491877/126830384-2c643df8-22b5-4b59-be18-93df253227da.png)
One Problem remaining is that the preferences do only allow three SortCriteria for Export at all with the current JabRefPreferences implementation. Changing that would mean I would have to add PreferenceMigrations OR i just allow three SortCriteria for now in the Export prefs tab.
Yet some very little issues left, i hope i can fix them the next days.
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)