-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak PDFContentImporter #945
Conversation
// The test folder contains pairs of PDFs and BibTeX files. We check each pair. | ||
// Currently only one pair available | ||
List<String> prefixes = Arrays.asList("LNCS-minimal"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't write this as a for loop and use parametrized tests instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like
public void testImport(sourcePdfName, shouldBeBibFileName) {
...
}
public void testLNCS() {
testImport("LNCS-minimal.pdf", "LNCS-minimal.bib")
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like https://github.com/junit-team/junit/wiki/Parameterized-tests and see the FormatterTest for an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
👍 |
👍 rebase and merge |
* Do not fill review field any more - this was used for debugging * Do not write empty keyword field * Remove newline at the end of abstract
c884bad
to
d6b8f90
Compare
This is a minor update on PdfContentImporter, which fixes minor issues and enables a broader test.