Tweak PDFContentImporter #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // The test folder contains pairs of PDFs and BibTeX files. We check each pair. | ||
| // Currently only one pair available | ||
| List<String> prefixes = Arrays.asList("LNCS-minimal"); |
There was a problem hiding this comment.
I wouldn't write this as a for loop and use parametrized tests instead.
There was a problem hiding this comment.
Like
public void testImport(sourcePdfName, shouldBeBibFileName) {
...
}
public void testLNCS() {
testImport("LNCS-minimal.pdf", "LNCS-minimal.bib")
}
There was a problem hiding this comment.
Like https://github.com/junit-team/junit/wiki/Parameterized-tests and see the FormatterTest for an example.
|
👍 |
|
👍 rebase and merge |
* Do not fill review field any more - this was used for debugging * Do not write empty keyword field * Remove newline at the end of abstract
koppor
force-pushed
the
tweakPdfContentImporter
branch
from
c884bad
to
d6b8f90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor update on PdfContentImporter, which fixes minor issues and enables a broader test.