Fixes citation key generation when authors list has "and others" at t… #9703

morganteg · 2023-03-26T07:51:43Z

…he end

Fixes koppor#626
Remove the statement "and others" at the end of authors list in order to generate a correct citation key.

Compulsory checks

Give feedback

Change in `CHANGELOG.md` described in a way that is understandable for the average user (if applicable)

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Options
Successfully updated the issue's project

There was an error updating the issue's project
Tests created for changes (if applicable)

Tests created for changes (if applicable)
Options
Successfully updated the issue's project

There was an error updating the issue's project
Manually tested changed features in running JabRef (always required)

Manually tested changed features in running JabRef (always required)
Options
Successfully updated the issue's project

There was an error updating the issue's project
Screenshots added in PR description (for UI changes)

Screenshots added in PR description (for UI changes)
Options
Successfully updated the issue's project

There was an error updating the issue's project
[Checked developer's documentation](https://devdocs.jabref.org/): Is the information available and up to date? If not, I outlined it in this pull request.

Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Options
Successfully updated the issue's project

There was an error updating the issue's project
[Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, I submitted a pull request to the documentation repository.

Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

src/main/java/org/jabref/logic/importer/AuthorListParser.java

Siedlerchr

from my side this looks good

calixtus · 2023-03-31T20:44:47Z

Looks good codewise to me too, thank you very much. Please add now a changelog entry, shorten the PR title a little bit so it fits in the char limit of github and check the checklist in the PR description. Then we can merge!

koppor · 2023-04-01T05:38:16Z

It just came into my.mind that BibTeX uses "+" to indicate "and others". For instance at the LNI stye / authorsalpha. Can that be done here, too?

ThiloteE · 2023-04-01T09:58:11Z

Tried this PR.

For citationkey pattern [auth][date]:

src/main/java/org/jabref/logic/importer/AuthorListParser.java

koppor · 2023-04-02T22:34:30Z

src/test/java/org/jabref/logic/citationkeypattern/CitationKeyGeneratorTest.java

+    void generateKeyCorrectKeyWithAndOthersAtTheEnd() {
+        BibEntry entry = createABibEntryAuthor("Alexander Artemenko and others");
+        entry.setField(StandardField.YEAR, "2019");
+        assertEquals("Artemenko2019", generateKey(entry, "[auth][year]"));


This is OK here.

We need another test with [authors] and [authorsAlpha]. -- They are roughly explained at https://docs.jabref.org/setup/citationkeypatterns#special-field-markers.

[authors] -> Artemenko+

[authorsAlpha] -> A+ (as far as I know. Can you setup a short Latex MWE to check?)

Fixed in c8df469 (#9703)

[authshort]: The last name if one author is given; the first character of up to three authors' last names if more than one author is given. A plus character is added, if there are more than three authors.

Fixed in b107f0a (#9703)

Siedlerchr · 2023-04-15T18:42:27Z

What's the status here? @koppor is this good now?

koppor · 2023-04-15T21:14:24Z

My comments were not adressed yet. With my code proposals, it shold be easy to finalize the PR. Maybe you can to the follow up @Siedlerchr if it is too much for @morganteg for now?

koppor · 2023-04-18T09:52:09Z

This PR is a follow up to #6300 (where @dextep probalby accidently added + to the set of unwanted characters org.jabref.logic.citationkeypattern.CitationKeyGenerator#DEFAULT_UNWANTED_CHARACTERS).

…he end JabRef#626 Remove the statement "and others" at the end of authors list in order to generate a correct citation key.

…for "and others"

Siedlerchr requested changes Mar 26, 2023

View reviewed changes

src/main/java/org/jabref/logic/importer/AuthorListParser.java Outdated Show resolved Hide resolved

ThiloteE added the keygenerator label Mar 27, 2023

morganteg force-pushed the fix-for-issue-626 branch from edfdcbc to a47d68a Compare March 28, 2023 14:03

morganteg marked this pull request as ready for review March 28, 2023 14:26

morganteg requested a review from Siedlerchr March 28, 2023 14:37

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 29, 2023

Siedlerchr previously approved these changes Mar 29, 2023

View reviewed changes

koppor requested changes Apr 2, 2023

View reviewed changes

koppor added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers status: changes required Pull requests that are not yet complete and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Apr 4, 2023

koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 15, 2023

koppor marked this pull request as draft April 15, 2023 21:14

koppor dismissed Siedlerchr’s stale review via 557c284 April 18, 2023 09:44

koppor added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: changes required Pull requests that are not yet complete labels Apr 18, 2023

koppor marked this pull request as ready for review April 18, 2023 09:53

koppor mentioned this pull request Apr 20, 2023

fix path for mac distribution portable #9779

Merged

koppor force-pushed the fix-for-issue-626 branch from f66a109 to eb50c41 Compare April 24, 2023 22:14

morganteg and others added 2 commits April 25, 2023 00:53

Fixes citation key generation when authors list has "and others" at t…

83842bf

…he end JabRef#626 Remove the statement "and others" at the end of authors list in order to generate a correct citation key.

Fix key generation for authors, authIniN, authorsAlpha and authShort …

c81e58e

…for "and others"

koppor force-pushed the fix-for-issue-626 branch from eb50c41 to c81e58e Compare April 24, 2023 22:54

calixtus approved these changes Apr 24, 2023

View reviewed changes

calixtus merged commit 21105b1 into JabRef:main Apr 24, 2023
10 checks passed

koppor mentioned this pull request Apr 24, 2023

Try parallel tests #9797

Merged

koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 27, 2023

koppor mentioned this pull request May 21, 2023

Add test for [authorIni] #9799

Merged

LoayGhreeb mentioned this pull request Mar 24, 2024

Incorrect bibkey creation for >4 authors #11087

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes citation key generation when authors list has "and others" at t… #9703

Fixes citation key generation when authors list has "and others" at t… #9703

morganteg commented Mar 26, 2023 •

edited by ThiloteE

Compulsory checks

Siedlerchr left a comment

calixtus commented Mar 31, 2023

koppor commented Apr 1, 2023

ThiloteE commented Apr 1, 2023 •

edited

koppor Apr 2, 2023

koppor Apr 20, 2023

Siedlerchr Apr 20, 2023

koppor Apr 21, 2023

Siedlerchr commented Apr 15, 2023

koppor commented Apr 15, 2023

koppor commented Apr 18, 2023

Fixes citation key generation when authors list has "and others" at t… #9703

Fixes citation key generation when authors list has "and others" at t… #9703

Conversation

morganteg commented Mar 26, 2023 • edited by ThiloteE

Compulsory checks

Siedlerchr left a comment

Choose a reason for hiding this comment

calixtus commented Mar 31, 2023

koppor commented Apr 1, 2023

ThiloteE commented Apr 1, 2023 • edited

koppor Apr 2, 2023

Choose a reason for hiding this comment

koppor Apr 20, 2023

Choose a reason for hiding this comment

Siedlerchr Apr 20, 2023

Choose a reason for hiding this comment

koppor Apr 21, 2023

Choose a reason for hiding this comment

Siedlerchr commented Apr 15, 2023

koppor commented Apr 15, 2023

koppor commented Apr 18, 2023

morganteg commented Mar 26, 2023 •

edited by ThiloteE

ThiloteE commented Apr 1, 2023 •

edited