Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix path for mac distribution portable #9779

Merged
merged 4 commits into from
Apr 20, 2023
Merged

fix path for mac distribution portable #9779

merged 4 commits into from
Apr 20, 2023

Conversation

Siedlerchr
Copy link
Member

Compulsory checks

Edit tasklist title
Beta Give feedback Tasklist Compulsory checks, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
    Options
  2. Tests created for changes (if applicable)
    Options
  3. Manually tested changed features in running JabRef (always required)
    Options
  4. Screenshots added in PR description (for UI changes)
    Options
  5. Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
    Options
  6. Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.
    Options

@Siedlerchr Siedlerchr closed this Apr 19, 2023
@koppor koppor reopened this Apr 20, 2023
@koppor
Copy link
Member

koppor commented Apr 20, 2023

Reopening to be able to check.

@koppor
Copy link
Member

koppor commented Apr 20, 2023

The current issue is

/Users/runner/work/_temp/4eb3eb11-31ab-4411-8cc1-857509e9f06f.sh: line 1: build/distribution/JabRef-portable_macos.tar.gz: No such file or directory
tar: could not chdir to 'build/distribution'

Thus, there is no folder build/distrubtion created during the workflow.

There is, however, a portable edition creaated for main:

image

@koppor
Copy link
Member

koppor commented Apr 20, 2023

This PR is a follow-up to #9767. At that PR, mac OS portable generation was "fixed". However, only in the precence of the secrets. This PR fixes the behavior in the absence of secretes.

Needs to be tried out at PRs from contributors.

I consider this as hotfix, so I merge after tests are green.

@koppor koppor merged commit ca9d841 into main Apr 20, 2023
12 checks passed
@koppor koppor deleted the fixWorkflowMac branch April 20, 2023 08:00
@koppor
Copy link
Member

koppor commented Apr 20, 2023

Tried at #9703 - works!

koppor added a commit that referenced this pull request Apr 21, 2023
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants