Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences ui cleanup B #9866

Merged
merged 37 commits into from
May 15, 2023
Merged

Preferences ui cleanup B #9866

merged 37 commits into from
May 15, 2023

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented May 9, 2023

Follow up to #9839

  • moved memory stick mode toggle to toolbar
    grafik

  • removed general tab and general preferences

  • polished KeyBindingsTab
    grafik

  • added missing symbols in CustomImporterTab / CustomExporterTab
    grafik

  • added small border to combobox popups (before / after)
    grafik grafik

  • renamed AppearanceTab to WorkspaceTab and reworked it, AppearancePreferences to WorkspacePreferences

  • merged LibraryTab with WorkspaceTab
    grafik

  • moved Autocompletion into its own tab und moved Custom entry editor tabs settings into EntryEditorTab
    grafik
    grafik

  • reordered preferences tabs
    grafik
    grafik

.

Compulsory checks

@calixtus calixtus added ui type: code-quality Issues related to code or architecture decisions preferences labels May 9, 2023
@JabRef JabRef deleted a comment from github-actions bot May 9, 2023
@JabRef JabRef deleted a comment from github-actions bot May 9, 2023
@Siedlerchr
Copy link
Member

Open last libraries on startup should be in libraries tab and not in appearance tab

@calixtus
Copy link
Member Author

Imho not, because you do not configure a library option, but the behaviour of the GUI.

@koppor
Copy link
Member

koppor commented May 10, 2023

Difficult UX discussion. I lean towards the libraries tab, because this is more empty than the other.

@calixtus
Copy link
Member Author

If I would look for an option about the startup of the GUI and how the GUI should look, I would not look at first in the libraries tab. The contents of a preference tab configure the inner behaviour of the feature. To show the last opened library on startup has nothing to do with how libraries should behave.

@Siedlerchr
Copy link
Member

Siedlerchr commented May 10, 2023

But semantically it is related to the library. Logical grouping of functions.
Appearence has the clear denotion of changing styles, e.g theme fonts etc

@Siedlerchr
Copy link
Member

We deffo schould ask our users!

@koppor
Copy link
Member

koppor commented May 10, 2023

Two scenarios (two times two tabs side by side; picture) then let vote? 😅

@calixtus
Copy link
Member Author

Proposed change with this PR:
grafik

Mockup with the "open last files on startup" in the libraries tab.
grafik

We probably should then also include the setting to open the last opened shared databases here too (#9843)

JabRefFrame and JabRefGUI will have to be changed to use the LibraryPreferences.
grafik

Imho, this is nonsense.

@calixtus
Copy link
Member Author

A quick survey on different applications:

How IntelliJ handles it:
grafik

VSCode sorts a compareable option in "Workbench"
grafik

Firefox in General:
grafik

MSOffice / Notepad++ / Gimp / does not provide that feature (at least i did not find it)

@Siedlerchr can you please check, how eclipse handles this and post a screenshot?

calixtus and others added 8 commits May 11, 2023 00:33
# Conflicts:
#	src/main/java/org/jabref/cli/ArgumentProcessor.java
#	src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java
#	src/main/java/org/jabref/logic/autosaveandbackup/BackupManager.java
#	src/main/java/org/jabref/logic/crawler/StudyRepository.java
koppor
koppor previously approved these changes May 12, 2023
@@ -18,6 +18,9 @@
import org.jabref.gui.externalfiletype.ExternalFileType;
import org.jabref.model.strings.StringUtil;

/**
Preferences for the linked files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMissingLeadingAsteriskCheck> reported by reviewdog 🐶
Javadoc line should start with leading asterisk.

@github-actions
Copy link
Contributor

Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.

More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html.

@Siedlerchr Siedlerchr merged commit 14a52c9 into main May 15, 2023
@Siedlerchr Siedlerchr deleted the library_prefs branch May 15, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences type: code-quality Issues related to code or architecture decisions ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants