Reworked TransformAndExtractUrls and fixed tests for it. #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rks. It now decodes the message first, then re-encodes the relevant parts if they match. The RegEx for URL parsing was also reworked according to http://daringfireball.net/2010/07/improved_regex_for_matching_urls !
samandmoore
added a commit
that referenced
this pull request
Sep 27, 2012
Reworked TransformAndExtractUrls and fixed tests for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now decodes the message first, then re-encodes the relevant parts if they match. The RegEx for URL parsing was also reworked according to http://daringfireball.net/2010/07/improved_regex_for_matching_urls
Two tests for this method were added and one broken test fixed. The broken test was passing non-encoded data to the method when in reality the method always gets passed encoded messages. This allows the method to decode the message first and then re-encode the relevant parts.
Should resolve issue #537