Improvements to better pause menu #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A "Back" wasn't all caps - A "Page" wasn't all caps - Two "Screen gamma"s didn't have a colon - "Open/Close Inventory" was too long
- Center pause menu title text to match ending screen title text - Move user track mode text to right of tick box like it is in main menu - Declare TempStr as a local in menu drawing functions (and rename it to the more common strtemp) - Center save file and custom map info text - Fix SlideBar "LOW" and "HIGH" text being considerably lower than the bar
- Horizontally center "YES" and "NO" deletion confirmation buttons - Better align "ACHIEVEMENTS" and "MAIN MENU" buttons on ending screen - Make achievement menu page buttons square and add disabled buttons to match load game/load map page buttons
It looks perfect at native 1024p now, but due to rounding errors with the menu scaling system, some menu elements still get misaligned by 1px at higher resolutions... I think ideally all coordinates should be floats, and nothing should be multiplied by MenuScale until the moment buttons/frames are drawn. Removing all instances of *MenuScale would be a hassle though...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
Before:
After:
