Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when copying text from first time receive window is shown #83

Closed
2 tasks done
Jacalz opened this issue May 9, 2023 · 1 comment
Closed
2 tasks done

Crash when copying text from first time receive window is shown #83

Jacalz opened this issue May 9, 2023 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@Jacalz
Copy link
Owner

Jacalz commented May 9, 2023

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Description

Crash when I, the receiver on CentOS 7, copied text. Worked up until some point.

Sender (Ubuntu 22.04):

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0xfc8070]

goroutine 285 [running]:
github.com/Jacalz/rymdport/v3/internal/util.(*ProgressBar).WithProgress.func1.1()
      github.com/Jacalz/rymdport/v3/internal/util/progress.go:19 +0x10
sync.(*Once).doSlow(0xc0036738c0?, 0xc006e9fd68?)
      sync/once.go:74 +0xc2
sync.(*Once).Do(...)
      sync/once.go:65
github.com/Jacalz/rymdport/v3/internal/util.(*ProgressBar).WithProgress.func1(0x3780?, 0x4d73e0?)
      github.com/Jacalz/rymdport/v3/internal/util/progress.go:19 +0x65
github.com/psanford/wormhole-william/wormhole.(*Client).SendText.func1()
      github.com/psanford/wormhole-william@v1.0.6/wormhole/send.go:170 +0x779
created by github.com/psanford/wormhole-william/wormhole.(*Client).SendText
      github.com/psanford/wormhole-william@v1.0.6/wormhole/send.go:71 +0x551

Receiver (CentOS 7):

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0xfca704]

goroutine 54 [running]:
github.com/Jacalz/rymdport/v3/internal/transport.(*Client).showTextReceiveWindow.func2()
      github.com/Jacalz/rymdport/v3/internal/transport/display.go:51 +0x24
fyne.io/fyne/v2/widget.(*Button).Tapped(0xc00406e000, 0xc002a22f01)
      fyne.io/fyne/v2@v2.3.4/widget/button.go:202 +0x53
fyne.io/fyne/v2/internal/driver/glfw.(*window).mouseClickedHandleTapDoubleTap.func1()
      fyne.io/fyne/v2@v2.3.4/internal/driver/glfw/window.go:634 +0x26
fyne.io/fyne/v2/internal/driver/common.(*Window).RunEventQueue(0x0?)
      fyne.io/fyne/v2@v2.3.4/internal/driver/common/window.go:35 +0x3e
created by fyne.io/fyne/v2/internal/driver/glfw.(*gLDriver).createWindow.func1
      fyne.io/fyne/v2@v2.3.4/internal/driver/glfw/window.go:946 +0x136

Steps to Reproduce

  1. Press the copy button on CentOS 7.

Screenshots

No response

Rymdport version

3.3.5

Operating System

Linux

Operating System Version

CentOS 7 and Ubuntu 22.04

Go Compiler Version

1.19.6

Additional Information

No response

@Jacalz Jacalz added the bug Something isn't working label May 9, 2023
@Jacalz Jacalz added this to the v3.3.x milestone May 9, 2023
Jacalz added a commit that referenced this issue May 11, 2023
If the window hadn't been shown before then there would be a crash due to there being no window viewport for the clipboard to attach to. Should fix one of the crashes in the issue linked below.

For #83
@Jacalz Jacalz changed the title Hard to reproduce crash on copying text Crash when copying text from first time receive window is shown May 11, 2023
@Jacalz
Copy link
Owner Author

Jacalz commented May 11, 2023

The second crash seems to be unrelated to the first but is also already fixed on the next branch ready for v3.4.0 in a few weeks. Will close this as resolved.

@Jacalz Jacalz closed this as completed May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant