Skip to content

Commit

Permalink
core: baseIndexer. change the GUID generation order. resolves #12463
Browse files Browse the repository at this point in the history
try the link first, then the magnet, then the details.

By defaulting to details first, cardigann indexers can in some cases create the same GUID for different torrents under the one title group.
  • Loading branch information
garfield69 committed Oct 26, 2021
1 parent 0942fc1 commit 3ca7f6b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/Jackett.Common/Indexers/BaseIndexer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -306,12 +306,12 @@ protected virtual IEnumerable<ReleaseInfo> FixResults(TorznabQuery query, IEnume
// set guid
if (r.Guid == null)
{
if (r.Details != null)
r.Guid = r.Details;
else if (r.Link != null)
if (r.Link != null)
r.Guid = r.Link;
else if (r.MagnetUri != null)
r.Guid = r.MagnetUri;
else if (r.Details != null)
r.Guid = r.Details;
}
return r;
Expand Down

1 comment on commit 3ca7f6b

@garfield69
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to publish this asap because it may impact pretty much all the json cardigann indexers, if they have a single details page links for titles with multiple torrents.
currently only YTS has been positively identifies as a victim.

Please sign in to comment.