Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RARBG show IMDb search capability missing #12127

Closed
agneevX opened this issue Aug 4, 2021 · 5 comments · Fixed by #12225
Closed

RARBG show IMDb search capability missing #12127

agneevX opened this issue Aug 4, 2021 · 5 comments · Fixed by #12225
Labels
Enhancement Needs C# PR Welcome! We would welcome a volunteer to prepare a PR to solve this problem!

Comments

@agneevX
Copy link
Contributor

agneevX commented Aug 4, 2021

Environment

OS: Ubuntu Linux
.Net Runtime: Docker install
.Net Version:
Jackett Version: 0.18.523
Last Working Jackett Version: N/A
Are you using a proxy or VPN?: No

Description

It seems that the RARBG indexer does not support IMDb searching for TV shows or Jackett is incorrectly reporting this.

<caps>
  <server title="Jackett"/>
  <searching>
    <search available="yes" supportedParams="q"/>
    <tv-search available="yes" supportedParams="q,season,ep"/>
...
  </searching>
</caps>

From my testing, RARBG supports this if two parameters are used together, i.e. search_imdb for the IMDb query and search_string for the remaining torznab query data, e.g. S02E01:

curl "https://torrentapi.org/pubapi_v2.php?app_id=jackett&token=xxx&mode=search&search_imdb=tt10986410&search_string=S02E01"

Can this be added?

Screenshots

@garfield69
Copy link
Contributor

garfield69 commented Aug 5, 2021

support for tv search in combination with imdb was handicapped by issue #8107 which is still open.

however it should be possible to amend the rarbg indexer if the correct support logic is added, i.e.
if it is a tv-search and an imdb is provided and the season and episode are present then build the correct rarbg api query.

however it should be noted that the official rarbg API docs does not document the use of search_imdb and search_string combo (see https://torrentapi.org/apidocs_v2.txt?app_id=Jackett )

anyway, since this is a C# indexer it will require a c# volunteer to provide the necessary code support.

@garfield69 garfield69 added Enhancement Needs C# PR Welcome! We would welcome a volunteer to prepare a PR to solve this problem! labels Aug 5, 2021
@mikeoscar2006
Copy link
Collaborator

The logic here is fine but after issue #8107, It can't be a tv-search since it's disabled for all indexers isn't it?

@garfield69
Copy link
Contributor

Given that the rarbg indexer is written in c# the indexer can be adjusted individually.
The global disabling applies to all the indexers that are written in yaml, as the cardigann processor is where the tv-search/imdb coupling was disabled affecting all those indexers.

@mikeoscar2006
Copy link
Collaborator

Got it. Interested in fixing this. Would soon open a PR if it's alright.

@garfield69
Copy link
Contributor

v0.18.623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Needs C# PR Welcome! We would welcome a volunteer to prepare a PR to solve this problem!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants