Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ygg Indexer Issue] (Saison) parsing in api calls is not working. #6207

Closed
ruCyberPoison opened this issue Oct 18, 2019 · 11 comments
Closed
Assignees

Comments

@ruCyberPoison
Copy link

ruCyberPoison commented Oct 18, 2019

Hello Dev's i have an issue with the torznab api from yggtorrent the semi-private torrent, i found
many series with the name 'Saison' and the api upstream doesn't appear on the sonarr v3/v2, so this is why i opening this ticket because sonarr have received a commit with the 'saison' parser on the name of season, but now the api call are replacing the saison to a 's'

Sonarr/Sonarr@ceaaec5

 - name: re_replace
            args: ["([Ss]aison|[Ss]aison )(\\d{1,4})", "S$2"]
          - name: re_replace
            args: ["S(\\d+)E(\\d+)(\\D+)", "S$1E$2 $3"]
          - name: re_replace
            args: ["([Mm][Uu][Ll][Tt][Ii])", "MULTi"]
          # End tidy up for sonarrv3 season search

but if you takes a better look in ygg to easily way you find Seasons packs with the name seasons

image
https://www2.yggtorrent.pe/engine/search?name=the+good+wife&do=search

but the jackett api call is returning only
image

can you do a edit please and update your docker image after that

@ruCyberPoison
Copy link
Author

i have tried without

- name: re_replace
            args: ["([Ss]aison|[Ss]aison )(\\d{1,4})", "S$2"]
          - name: re_replace
            args: ["S(\\d+)E(\\d+)(\\D+)", "S$1E$2 $3"]
          - name: re_replace
            args: ["([Mm][Uu][Ll][Tt][Ii])", "MULTi"]
          # End tidy up for sonarrv3 season 

this doesn't work for me. this need a fix

@ruCyberPoison ruCyberPoison changed the title Ygg (Saison) parsing in api calls is not working. [Ygg Indexer Issue] (Saison) parsing in api calls is not working. Oct 21, 2019
@ngosang
Copy link
Member

ngosang commented Jan 11, 2020

@garfield69 ping

@garfield69
Copy link
Contributor

@xfouloux you've been maintaining this indexer recently, care to look at this ticket?

@xfouloux
Copy link
Contributor

I will look into it, but last time i scratched my head with this
Problem is YGG tracker and their search engine that is bad.

Sonarr will search like this for a season :
"The Good Wife S1" and that will not match or return any result in YGG search

If you search for "The Good Wife" from jackett, it will return the results.

The problem is that we need to transform the Sonarr queryWord into something that would match in YGG, but if we convert the "S1" to "Saison 1" then it will not work for other results that are Scene named correctly.

I might try to add a second query search then but i don't know know to transform the QueryWord into a variable that can be then used into a second search

I think that we need C# for this....

@garfield69
Copy link
Contributor

veto the second query search, do not want to go down that path.
I'll take a look at the current yggtorrent (shudder, I detest this shitty web site) and see if I can improve the pre-and post processing of the titles

so to recap we need to handle

Good Wife S06
Good Wife saison 6
Good Wife season 6
Good Wife S06E01

is that every combo?

@xfouloux
Copy link
Contributor

Well Sonarr will send for

  • Season Search : "The Good Wife Sx"
  • Episode Search : "The Good Wife SxEy"

Not sure about the "The",

But what we want to search in YGG is :

  • Season Search : "Good Wife Sx" or "Good Wife saison x" or "Good Wife season x" or "Good Wife S0x" or "Good Wife saison 0x" or "Good Wife season 0x"
  • Episode Search : "The Good Wife SxEy" or "Good Wife saison xx episode y"

i think ygg does not return result for something that is like that "Good Wife S06" if you don't put the 0 and search like "Good Wife S6" ==> need to try and see

that should match pretty much everything

@RoloSoze
Copy link
Collaborator

@xfouloux @garfield69 Verdict on this issue?

@garfield69
Copy link
Contributor

i'ts on my queue, but at the bottom, because I hate this site. I will take a look at it eventually once I clear my queue, which by the way, is currently 62 emails deep and counting.

@garfield69 garfield69 self-assigned this Apr 12, 2020
@xfouloux
Copy link
Contributor

The best thing would be to make it in C# and use the url to make it look for a season in particular using the select box ids but that will be a pain in the ass too

@xfouloux
Copy link
Contributor

xfouloux commented Jul 7, 2020

What it does now, is :

When Sonarr send : The Good Wife S1
It search for "The Good Wife S01" & "The Good Wife Saison.1" & "The Good Wife Saison.01"

It then displays result by tidying everything in the format sonarr wants which is "The Good Wife S01" even if the result what was found was "The Good Wife Saison.01" or "The Good Wife Saison 01"

It should solve most of the issues.

I still encounter some issue with stuff like "Dawson's Creek" for example, sonarr search for "Dawsons Creek S1" but then title of the torrent in YGG is : "DAWSON SAISON 1 1998 DVDRIP MULTI + ST H264 AAC DAWSON'S CREEK" so because the search engine is strict it doesn't find it

So it may happen for other TV shows

Fix for this is to use the beta search engine, it's returning way too much results to be let on by default, or have a path search with the beta engine to complete the other search. So just activate the beta search in jackett at your own risk, or only sometimes manually when searching.

garfield69 added a commit that referenced this issue Jul 8, 2020
@garfield69
Copy link
Contributor

Jackett 0.16.814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants