Update to .NET 5 #10346

ghost · 2020-12-02T11:06:54Z

.NET 5 brings many performance (especially regex) improvements
https://devblogs.microsoft.com/dotnet/announcing-net-5-0/

Can look at bringing the packages upto date and using a single file executable in a future PR if the maintainers are interested

.NET 5 brings many performance (especially regex) improvements https://devblogs.microsoft.com/dotnet/announcing-net-5-0/ Can look at bringing the packages upto date and using a single file executable in a future PR if the maintainers are interested

ghost · 2020-12-02T12:36:09Z

Run out of time for now, will try and have another look this weekend (unless some one else is keen!)
It's building and integration tests are passing on Windows, Mac and Linux. Integration tests are failing on Mono though. Will try and spin up a VM with Mono. If any of the maintainers have a Mono machine, if could you could try the Mono build that would be great in helping to see if its a build problem or a test problem

ngosang · 2020-12-02T19:06:07Z

@garfield69 @ilike2burnthing I have a lot of work lately. I can only spend time on this project on the weekend. I will go over all the important assignments on Saturday or Sunday. If something can't wait that long, you don't have to wait for me.

ghost · 2020-12-03T10:25:16Z

Fixed the issue with Mono, really great work from the maintainers having those integration tests, pretty unusual in OSS

ilike2burnthing · 2020-12-03T10:31:08Z

As far as I'm aware, all praise goes to @ngosang (at least of late) for those

garfield69

I am extremely confused.

Ran my win10 VirtualBox and started ubuntu 18.04, downloaded the amd package from this PR, extracted it and ran the systemd installer
and the Jackett log shows:

2020-12-04 16:34:21 Info Using HTTP Client: HttpWebClient
2020-12-04 16:34:21 Info Using proxy: Disabled
2020-12-04 16:34:21 Info App config/log directory: /home/garfield69/.config/Jackett
2020-12-04 16:34:21 Info ThreadPool MaxThreads: 32767 workerThreads, 1000 completionPortThreads
2020-12-04 16:34:21 Info Running in Docker: No
2020-12-04 16:34:21 Info File /etc/issue: Ubuntu 18.04.5 LTS \n \l
2020-12-04 16:34:21 Info Jackett variant: Mono
2020-12-04 16:34:21 Info OS version: Unix 4.15.0.126 (64bit OS) (64bit process)
2020-12-04 16:34:21 Info Environment version: 5.0.0 (/home/garfield69/Downloads/Jackett.Binaries.LinuxAMDx64/Jackett/)
2020-12-04 16:34:18 Info Starting Jackett v0.16.2296.0

Was expecting Jackett variant CoreLinuxAmdx64 not Mono

downloaded the win package, installed and the Jackett log shows:

2020-12-04 16:47:02 Info Using HTTP Client: HttpWebClient
2020-12-04 16:47:02 Info Using proxy: Disabled
2020-12-04 16:47:02 Info App config/log directory: C:\ProgramData\Jackett
2020-12-04 16:47:02 Info ThreadPool MaxThreads: 682 workerThreads, 1000 completionPortThreads
2020-12-04 16:47:02 Info Running in Docker: No
2020-12-04 16:47:02 Info Jackett variant: FullFrameworkWindows
2020-12-04 16:47:02 Info OS version: Microsoft Windows NT 10.0.19042.0 (64bit OS)
2020-12-04 16:47:02 Info Environment version: 5.0.0 (C:\ProgramData\Jackett\)
2020-12-04 16:47:01 Info Starting Jackett v0.16.2296.0

Was expecting Jackett variant CoreWindows not FullFrameworkWindows

Ran win10 VirtualBox and started BigSur, downloaded the mac package, installed and the Jackett log shows:

2020-12-04 21:32:28 Info Using HTTP Client: HttpWebClient
2020-12-04 21:32:28 Info Using proxy: Disabled
2020-12-04 21:32:28 Info App config/log directory: /Users/garfield69/.config/Jackett
2020-12-04 21:32:28 Info ThreadPool MaxThreads: 32767 workerThreads, 1000 completionPortThreads
2020-12-04 21:32:28 Info Running in Docker: No
2020-12-04 21:32:28 Info Jackett variant: Mono
2020-12-04 21:32:28 Info OS version: Unix 11.0.0 (64bit OS) (64bit process)
2020-12-04 21:32:28 Info Environment version: 5.0.0 (/Users/garfield69/Downloads/Jackett/)
2020-12-04 21:31:58 Info Starting Jackett v0.16.2296.0

Was expecting Jackett variant CoreMacOs not Mono

garfield69 · 2020-12-04T06:58:43Z

looks like it is failing this conditional

Jackett/src/Jackett.Common/Utils/Variants.cs

Line 22 in 6b4b56f

if (DotNetCoreUtil.IsRunningOnDotNetCore)

garfield69 · 2020-12-04T08:53:54Z

so this

Jackett/src/Jackett.Common/Utils/DotNetCoreUtil.cs

Line 16 in 6b4b56f

    
           runningOnDotNetCore = RuntimeInformation.FrameworkDescription.IndexOf("core", StringComparison.OrdinalIgnoreCase) >= 0;

no longer contains core when .net 5 is active
https://docs.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.runtimeinformation.frameworkdescription?view=net-5.0

ghost · 2020-12-04T09:42:14Z

Good pickup @garfield69 , sorry my bad
Rather than use FrameworkDescription I went with FrameworkName https://weblog.west-wind.com/posts/2018/Apr/12/Getting-the-NET-Core-Runtime-Version-in-a-Running-Application since it looks like FrameworkDescription is only supported in Full Framework from 4.7.1 and its always hard to know what that maps to in Mono. Whereas for every version of Jackett except Mono, the runtime is bundled so feels safer to look for that
Tested Windows and Mono and it now looks good to me

Also, I'd suggest bumping the minorVersion to 17 for this, but will leave that to you to decide

ngosang · 2020-12-06T20:56:18Z

ngosang · 2020-12-06T22:06:12Z

Compile warnings are not blocking this issue. They can be fixed later.
My main concern now is the memory usage (on Linux at least). Results after 1 search with 300 trackers enabled.

Linux x64 .netcore3.1 => total = 264 MB shared =69 MB
Linux x64 .netcore5.0 => total = 366 MB shared = 71 MB

@airhawk777 do you have some info to share? can it be related to the new dependencies included in this pr? memory usage in windows is similar?

ilike2burnthing · 2020-12-07T03:03:44Z

                            WS   Pe   Pr   Sh  Co   PP
Win10 x64 .netcore3.1 .exe  195  248  154  40  159  270
Win10 x64 .netcore5.0 .exe  183  201  140  43  145  340
Win10 x64 .netcore3.1 .zip  184  234  144  40  151  323
Win10 x64 .netcore5.0 .zip  187  206  142  43  149  355

Legend

WS- Working Set
Pe - Peak Working Set
Pr - Private Working Set
Sh - Shared Working Set
Co - Commit
PP - Paged Pool

221 indexers, of which 31 failed. 21 failed when using proxy/VPN, with little to no difference in memory. All are expected to fail (i.e. this isn't causing indexers to fail which weren't already).

Multiple runs (restarting the Jackett in between) had some variance, figures above show a rough average.

Log traces:

Jackett variant: CoreWindows
Environment version: 5.0.0

Manual updates from 3.1>5.0, 5.0>3.1, and 5.0>5.0 all worked fine without error.

ngosang · 2020-12-07T20:06:39Z

I did all test in Linux / Mono / Docker and everything is fine.
I was measuring the memory wrong. After using another tool I get similar results to @ilike2burnthing Memory is almost the same.

@garfield69 Could you perform some tests in MacOS and WindowsXP ? If test pass you can merge.

garfield69 · 2020-12-07T21:15:53Z

tested OK on my win10 VirtualBox macOS Big Sur image.
Don't have an winXP image ready to use, I will dig into my archives an see if I still have a XP installer.

ilike2burnthing · 2020-12-07T21:23:10Z

If needed, you can extract the VHD from the XP Mode installer - https://www.microsoft.com/en-us/download/details.aspx?id=8002

Got it up and running using Hyper-V, but couldn't get internet access for whatever reason.

ngosang · 2020-12-07T21:26:43Z

https://www.makeuseof.com/tag/download-windows-xp-for-free-and-legally-straight-from-microsoft-si/

garfield69 · 2020-12-07T21:39:40Z

found my winXP sp4 installer cd, installing into VirtualBox image as I type this. Should be done in the next couple hours ;-)

ghost · 2020-12-08T01:53:32Z

Will have a look at the compile warnings when I get some spare time. Looks like a new warning with .net 5 so will follow this issue dotnet/sdk#14502 it shouldn’t cause any issues since it’s been doing this all along

Doubt jackett even with current release will work on xp since .NET core requires win7. Jackett read me also specifies a minimum of win7 as well

garfield69 · 2020-12-08T07:54:49Z

WinXP is unsupported as pointed out by airhawk777
Set up Win7sp1 and tested PR both with installer package and zip package. All good.

Will bump the minorversion to 17 on this PR and then publish as a pre-release

garfield69 · 2020-12-08T08:56:35Z

testing check-for-updates upgrading from 0.16.2374 to 0.17.3 pre-release on win10, win7sp1, ubuntu18,04 and BigSur
All good. ;-)

ngosang · 2020-12-08T09:10:00Z

Nice job! Thank you very much to all.

ghost · 2021-03-03T17:56:35Z

@airhawk777

Sorry if this is the wrong place to ask, but I'm getting errors that I'm unfamiliar with. Everything was fine until I updated my Visual Studio 2019 to version 16.9. I am now getting these errors:

NETSDK1005 Assets file 'C:\Users\...\source\repos\Jackett\src\Jackett.Server\obj\project.assets.json' doesn't have a target for 'net5.0'. Ensure that restore has run and that you have included 'net5.0' in the TargetFrameworks for your project.

NU1201 Project Jackett.Server is not compatible with net5.0 (.NETCoreApp,Version=v5.0). Project Jackett.Server does not support any target frameworks.

dotnet restore only restored 4 of 8 projects. I tried removing my cached NuGet packages, bin and obj folders...

I eventually found the fix, which is to add <RuntimeIdentifier>win-x64</RuntimeIdentifier> after the <TargetFrameworks> in Jackett.Server.csproj.

Can someone tell me why I needed to do this now and not before the VS update? Am I doing something wrong or have they changed the way you're supposed to add frameworks? Is this something we should add to this change or am I the only one experiencing this error? And if we were to add this to master, would this have an effect on other platforms (because it's targeting Windows, which I'm developing on)?

garfield69 · 2021-03-04T23:08:19Z

@XYZJR I don't know much about your particular issue, but whenever my VS upgrades and I get a problem I just access the tools->nuGet packet manager->packet manager console, and when the prompt is ready and type dotnet restore
then do a build->clean solution followed by a build-> build solution and I'm good till next time.
I've not seeing your exact issue so far on my win VS 2019 16.9.0
In the past when it really got stuffed up, I deleted my local repo, and followed https://github.com/Jackett/Jackett#windows to reset and get going again.

ghost · 2021-03-05T17:15:49Z

@garfield69 I re-installed .NET 5 SDK and Visual Studio, then re-cloned the project. dotnet restore, rebuild, the whole thing... It's still giving those same errors.

garfield69 · 2021-03-05T17:31:36Z

@XYZJR that's unfortunate.
I'm not a C# dev, and I only use VS occasionally for testing simple Jackett C# PRs when there are no proper C# devs available.
So that is all the experience I have with the product, sorry.

ilike2burnthing · 2021-05-01T22:57:44Z

@XYZJR here's a fix from @JigSawFr:

After cloning your fork, execute these commands:

- dotnet msbuild /restore
- dotnet restore
- dotnet build

And it will work as expected otherwise server project building will fail. :)

airhawk777 added 5 commits December 2, 2020 22:04

Update to .NET 5

3bc55df

.NET 5 brings many performance (especially regex) improvements https://devblogs.microsoft.com/dotnet/announcing-net-5-0/ Can look at bringing the packages upto date and using a single file executable in a future PR if the maintainers are interested

Dotnet restore before building

a0ccec4

Restore on Windows only

ca0baf6

Out of ideas

7d42e8b

Update framework for windows specific apps

c62b2f1

garfield69 requested a review from ngosang December 2, 2020 17:35

Don't upgrade Microsoft.Extensions.Configuration

7f071f1

garfield69 added 2 commits December 4, 2020 08:52

drop mono from the dotnet linux build instructions

2b4b93a

Merge branch 'master' into net5

79f1aa0

garfield69 requested changes Dec 4, 2020

View reviewed changes

Fix logic to get app runtime

26438f7

Merge branch 'master' into net5

6e87a47

Merge branch 'master' into net5

2277395

ngosang approved these changes Dec 7, 2020

View reviewed changes

Merge branch 'master' into net5

d293ebd

ngosang mentioned this pull request Dec 7, 2020

core: fix .net5.0 warnings #10433

Closed

Merge branch 'master' into net5

96c97c0

garfield69 added 2 commits December 8, 2020 20:21

readme: add windows .net prereq link

850e50a

Update README.md

9dea611

garfield69 approved these changes Dec 8, 2020

View reviewed changes

garfield69 added 2 commits December 8, 2020 20:55

azure-pipeline: bump minorversion to 17

2b66e18

Merge branch 'master' into net5

9b5654b

garfield69 merged commit 65ca4d7 into Jackett:master Dec 8, 2020

ilike2burnthing mentioned this pull request May 6, 2021

[Feature] Filter Meta Indexer by tag and by language #11662

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to .NET 5 #10346

Update to .NET 5 #10346

ghost commented Dec 2, 2020

ghost commented Dec 2, 2020

ngosang commented Dec 2, 2020

ghost commented Dec 3, 2020

ilike2burnthing commented Dec 3, 2020

garfield69 left a comment

garfield69 commented Dec 4, 2020

garfield69 commented Dec 4, 2020

ghost commented Dec 4, 2020

ngosang commented Dec 6, 2020 •

edited by garfield69

Loading

ngosang commented Dec 6, 2020

ilike2burnthing commented Dec 7, 2020

ngosang commented Dec 7, 2020

garfield69 commented Dec 7, 2020

ilike2burnthing commented Dec 7, 2020

ngosang commented Dec 7, 2020

garfield69 commented Dec 7, 2020

ghost commented Dec 8, 2020

garfield69 commented Dec 8, 2020

garfield69 commented Dec 8, 2020

ngosang commented Dec 8, 2020

ghost commented Mar 3, 2021 •

edited by ghost

Loading

garfield69 commented Mar 4, 2021 •

edited

Loading

ghost commented Mar 5, 2021

garfield69 commented Mar 5, 2021

ilike2burnthing commented May 1, 2021

Update to .NET 5 #10346

Update to .NET 5 #10346

Conversation

ghost commented Dec 2, 2020

ghost commented Dec 2, 2020

ngosang commented Dec 2, 2020

ghost commented Dec 3, 2020

ilike2burnthing commented Dec 3, 2020

garfield69 left a comment

Choose a reason for hiding this comment

garfield69 commented Dec 4, 2020

garfield69 commented Dec 4, 2020

ghost commented Dec 4, 2020

ngosang commented Dec 6, 2020 • edited by garfield69 Loading

ngosang commented Dec 6, 2020

ilike2burnthing commented Dec 7, 2020

ngosang commented Dec 7, 2020

garfield69 commented Dec 7, 2020

ilike2burnthing commented Dec 7, 2020

ngosang commented Dec 7, 2020

garfield69 commented Dec 7, 2020

ghost commented Dec 8, 2020

garfield69 commented Dec 8, 2020

garfield69 commented Dec 8, 2020

ngosang commented Dec 8, 2020

ghost commented Mar 3, 2021 • edited by ghost Loading

garfield69 commented Mar 4, 2021 • edited Loading

ghost commented Mar 5, 2021

garfield69 commented Mar 5, 2021

ilike2burnthing commented May 1, 2021

ngosang commented Dec 6, 2020 •

edited by garfield69

Loading

ghost commented Mar 3, 2021 •

edited by ghost

Loading

garfield69 commented Mar 4, 2021 •

edited

Loading