Migrate configurations from bug fixed in #11173. Fixes #11313 #11347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, took a swing at blindly hoping I got the Window test right, going to try with |
|
I'm an idiot and forgot that Windows uses |
ghost
approved these changes
Mar 28, 2021
* remove dead code * invert existance check in PerformMigration
|
Okely Dokely. |
|
Thank you both for the reviews and assistance :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a configuration migration to address potential configurations addressed in #11173 by allowing the
PerformMigrationfunction ofConfigurationServiceto take a path to a previous configuration directory, and adding a check inCreateOrMigrateSettingsfor a misconfiguration.It also adds a test case for
RuntimeSettings.DataFolderto ensure the default configuration path matches expectations.