Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xthor: misc enhancements #11695

Merged
merged 3 commits into from May 8, 2021
Merged

xthor: misc enhancements #11695

merged 3 commits into from May 8, 2021

Conversation

JigSawFr
Copy link
Collaborator

@JigSawFr JigSawFr commented May 8, 2021 •
edited

  • New: Added categories dropping options (enabled, only for TMDB queries, disabled) - For TMDB queries by default
  • Improved: Removed search parameter when no search term submitted.

@JigSawFr JigSawFr self-assigned this May 8, 2021
@JigSawFr
Copy link
Collaborator Author

JigSawFr commented May 8, 2021

Categories are known problems for API if there are too many included in the request. (It will send bad results and duplicated on multiple pages). For TMDB queries, it's more accurate as only matched TMDB id are returned, so results are better (performance too).

@JigSawFr JigSawFr changed the title xthor: mis enhancements xthor: misc enhancements May 8, 2021
@ilike2burnthing
Copy link
Contributor

I don't have an account to test and am not a C# dev so can only comment generally, but if it's working for you, then this looks fine to me.

Just those two comments and those from the previous PR, pretty much all small things, e.g. we don't have questions in settings for any other indexer, so rephrasing things to avoid them here.

@JigSawFr
Copy link
Collaborator Author

JigSawFr commented May 8, 2021 •
edited

@ilike2burnthing thanks for your comments. For other's changes I will make another PR ;)
And even if you're not a C#vdev, I appreciate your comments and reviews !

@JigSawFr JigSawFr marked this pull request as ready for review May 8, 2021 19:46
@JigSawFr JigSawFr merged commit b07543b into Jackett:master May 8, 2021
@JigSawFr JigSawFr deleted the indexer/xthor branch May 8, 2021 19:52
@ilike2burnthing
Copy link
Contributor

v0.18.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilike2burnthing ilike2burnthing ilike2burnthing approved these changes

@garfield69 garfield69 Awaiting requested review from garfield69

Assignees

@JigSawFr JigSawFr

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JigSawFr @ilike2burnthing