-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Indexer Test status filter #11705
Conversation
Works well. No comments here. |
Hi guys, i did install the linked version (thanks @ilike2burnthing) however i am not 100% sure how i can easily test this, or verify that its working correctly, i took at look at the json for the index sites and couldn't spot any additional information being included which indicated a pass or fail, and i didnt spot any ui options to configure or display test information, maybe you can help me out here @ilike2burnthing and detail what you did to test it, sorry i must be having a blonde moment :-) i have tried to simulate a failed index site to see what would happen by changing the site link for a single index site to an invalid url, but it currently still shows as 'passed' when i click on 'Test all' which is a bit odd, i was expecting to at least see a failure shown. edit - i saw the other post from you @ilike2burnthing and i see the implementation is purely API only, so i guess i would need to alter the API call to jacket (from for example, sonarr) to perform the test, is this correct?. |
You can call directly Jackett from the browser using an URL like this
|
@alecsg77 perfect!, i get it now, can you just confirm the below filter is the correct syntax, im just getting my head around combining multiple filters and not 100% sure on it:-
so does that equate to: all indexers, of type NOT private (aka public), language english only, and only indexers with a test of passed, correct?. |
Be aware: tag:all doesn't mean "all the indexers" but "indexers with |
ahh sorry i wasn't aware of the significance of |
hmm so how can i AND all filters such that i can filter certain tagged index sites AND certain index site types AND language AND test passed?, e.g. filter (not working):-
edit - ignore me, it was my tag name that was incorrect, its working :-) |
Out of interest, is your |
no, it wasn't, thus the issue :-) |
I'm happy for this to be merged, however given that #11706 contains all the code for this PR, do you want to close this one and just focus on it? |
Partialy solution for Jackett#3292
Co-authored-by: ilike2burnthing <59480337+ilike2burnthing@users.noreply.github.com>
No, I want to keep them separated and deliver this before the other one. |
@binhex all working ok for you? |
it looks good from my side, it's actually already adding value for me as i had an outage on two of the indexers i have enabled and i could see they were marked as failed and the metadata downloader didn't seem to miss a beat :-), ignoring the 'failed' indexers, so im really happy with the change!. |
Thanks. This will hopefully be merged soon when garfield can take a look at it, so the next PR will be #11706 if you want to try that one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
played around with windows Sonarr and Jackett with a variety of filters and got the expected results.
v0.18.74 |
Partialy solution for #3292