Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Indexer Test status filter #11705

Merged
merged 5 commits into from
May 15, 2021
Merged

Conversation

alecsg77
Copy link
Contributor

Partialy solution for #3292

README.md Outdated Show resolved Hide resolved
@ilike2burnthing
Copy link
Contributor

I'll test this out tomorrow once I've slept and have a clear head, but in the mean time if anyone else (@binhex) wants to have a go - 0.18.20.

@binhex
Copy link

binhex commented May 10, 2021

but in the mean time if anyone else (@binhex) wants to have a go - 0.18.20.

absolutely!, i will let you know how i get on.

@ilike2burnthing
Copy link
Contributor

Works well. No comments here.

@binhex
Copy link

binhex commented May 11, 2021

Hi guys, i did install the linked version (thanks @ilike2burnthing) however i am not 100% sure how i can easily test this, or verify that its working correctly, i took at look at the json for the index sites and couldn't spot any additional information being included which indicated a pass or fail, and i didnt spot any ui options to configure or display test information, maybe you can help me out here @ilike2burnthing and detail what you did to test it, sorry i must be having a blonde moment :-)

i have tried to simulate a failed index site to see what would happen by changing the site link for a single index site to an invalid url, but it currently still shows as 'passed' when i click on 'Test all' which is a bit odd, i was expecting to at least see a failure shown.

edit - i saw the other post from you @ilike2burnthing and i see the implementation is purely API only, so i guess i would need to alter the API call to jacket (from for example, sonarr) to perform the test, is this correct?.

@alecsg77
Copy link
Contributor Author

You can call directly Jackett from the browser using an URL like this
http://<ip>:9117/api/v2.0/indexers/<filter>/results?apikey=<apiKey>&Query=<search>
and see the results 😃

<filter> will be test:passed or test:failed in this case.

@binhex
Copy link

binhex commented May 11, 2021

@alecsg77 perfect!, i get it now, can you just confirm the below filter is the correct syntax, im just getting my head around combining multiple filters and not 100% sure on it:-

tag:all,!type:private+lang:en+test:passed

so does that equate to: all indexers, of type NOT private (aka public), language english only, and only indexers with a test of passed, correct?.

@alecsg77
Copy link
Contributor Author

alecsg77 commented May 11, 2021

And operator have precedence over Or
so
indexers WHERE (Tags contains all) OR (Type is NOT private AND Language begin with en AND Test is passed)

Test is passed -> No Last Error

Be aware: tag:all doesn't mean "all the indexers" but "indexers with all tag", if you have tagged some of them with the word all

@binhex
Copy link

binhex commented May 11, 2021

ahh sorry i wasn't aware of the significance of , and + in the filter, thanks for that.

@binhex
Copy link

binhex commented May 11, 2021

hmm so how can i AND all filters such that i can filter certain tagged index sites AND certain index site types AND language AND test passed?, e.g. filter (not working):-

tag:all+type:public+lang:en+test:passed

edit - ignore me, it was my tag name that was incorrect, its working :-)

@ilike2burnthing
Copy link
Contributor

Out of interest, is your all tag on all your configured indexers?

@binhex
Copy link

binhex commented May 11, 2021

Out of interest, is your all tag on all your configured indexers?

no, it wasn't, thus the issue :-)

@ilike2burnthing
Copy link
Contributor

I'm happy for this to be merged, however given that #11706 contains all the code for this PR, do you want to close this one and just focus on it?

alecsg77 and others added 3 commits May 14, 2021 09:45
Co-authored-by: ilike2burnthing <59480337+ilike2burnthing@users.noreply.github.com>
@alecsg77
Copy link
Contributor Author

No, I want to keep them separated and deliver this before the other one.

@ilike2burnthing
Copy link
Contributor

@binhex all working ok for you?

@binhex
Copy link

binhex commented May 14, 2021

@binhex all working ok for you?

it looks good from my side, it's actually already adding value for me as i had an outage on two of the indexers i have enabled and i could see they were marked as failed and the metadata downloader didn't seem to miss a beat :-), ignoring the 'failed' indexers, so im really happy with the change!.

@ilike2burnthing
Copy link
Contributor

Thanks. This will hopefully be merged soon when garfield can take a look at it, so the next PR will be #11706 if you want to try that one.

Copy link
Contributor

@garfield69 garfield69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
played around with windows Sonarr and Jackett with a variety of filters and got the expected results.

@garfield69 garfield69 merged commit 6dab689 into Jackett:master May 15, 2021
@garfield69
Copy link
Contributor

v0.18.74

@alecsg77 alecsg77 deleted the test-filter branch May 20, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants