Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to select multiple public indexers at one time. #11721

Merged
merged 4 commits into from
May 17, 2021

Conversation

wdupree
Copy link
Contributor

@wdupree wdupree commented May 13, 2021

Add a checkbox column to the add indexers datatable which allows multiple selection of public indexers to add at one time.

@ilike2burnthing
Copy link
Contributor

Seems to work well, though I noticed that after adding multiple indexers I get Selected indexers successfully added. each time I delete an indexer. Refreshing the page stops this.

@wdupree
Copy link
Contributor Author

wdupree commented May 14, 2021

Seems to work well, though I noticed that after adding multiple indexers I get Selected indexers successfully added. each time I delete an indexer. Refreshing the page stops this.

hmm... I deleted indexers one at a time when I bulk added - I'll have to check and see what might be happening. Thanks for letting me know.

EDIT: hmm.. I can't get this to replicate on my end. I use Edge and Chrome; what browser are you using?

EDIT 2: I installed FIrefox on the dev VM and i see it happening... I'll look in to it!

@ilike2burnthing ilike2burnthing linked an issue May 15, 2021 that may be closed by this pull request
…ner; tweak message for individual success to show indexer name.
Copy link
Contributor Author

@wdupree wdupree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added changes to force the unbind from the ajaxstop listener

@ilike2burnthing
Copy link
Contributor

Can you resolve the conflict with index.html? It's just the change timestamp.

@garfield69
Copy link
Contributor

Can you resolve the conflict with index.html? It's just the change timestamp.

done.

@ilike2burnthing
Copy link
Contributor

Yep, that fixed it. Thanks for the contribution.

Copy link
Contributor

@garfield69 garfield69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cosmetic, but on my chrome, the Add Selected button does not behave the same way as the Close button right next to it.
The Close button starts with a white background, goes grey as you hover over it.
The Add Selected button always has a grey background.

Ideally the buttons should behave the same way. Can you update?

Copy link
Contributor

@garfield69 garfield69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorted :-)

@garfield69 garfield69 merged commit 7304ec2 into Jackett:master May 17, 2021
@wdupree wdupree deleted the wdupreeAddMultipleIndexers branch May 17, 2021 03:05
@wdupree
Copy link
Contributor Author

wdupree commented May 17, 2021

sorted :-)

Thanks :)

@garfield69
Copy link
Contributor

v0.18.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] multiple indexer add
3 participants