New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update animeworld.cx to new source #11852
Conversation
It's quite acceptable since torznab does not have a movies/anime category. |
Don't forget to update the readme.md and amend the current |
Co-authored-by: garfield69 <garfieldsixtynine@gmail.com>
Alright, I merged the music and book search from your review and removed the reference to ast4u from the readme. Thanks for looing over this :) I hope its fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ilike2burnthing feel like I've forgotten something... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though I think recent changes have been to set anime movies as Movies\Other
:
Jackett/src/Jackett.Common/Definitions/nyaasi.yml
Lines 83 to 88 in 1f1f42c
# Anime as Movies (Radarr uses t=movie): | |
- {id: 1_0, cat: Movies/Other, desc: "Anime"} | |
- {id: 1_1, cat: Movies/Other, desc: "Anime music videos"} | |
- {id: 1_2, cat: Movies/Other, desc: "English subtitled animes"} | |
- {id: 1_3, cat: Movies/Other, desc: "Non-english subtitled animes"} | |
- {id: 1_4, cat: Movies/Other, desc: "Raw animes"} |
See also dmhy.
Where the quality is part of the category name (e.g. SD, HD, BluRay, etc.) then Movies\SD
, Movies\HD
, Movies\BluRay
, etc. are used; see U2 and AnimeTorrents.
Co-authored-by: ilike2burnthing <59480337+ilike2burnthing@users.noreply.github.com>
Co-authored-by: ilike2burnthing <59480337+ilike2burnthing@users.noreply.github.com>
They only have one category for anime movies and movies in general, so I think movies/others is also a good mapping |
v0.18.225 |
animeworld.cx changed their source to unit3d, with this commit the jackett integration is working again.
They also had ast4u as their old trackername, but i removed those references as they now require a new registration and old accounts are not working anymore
I have one question though, they have a categorie for Anime Movies, which I mapped to "TV/Anime" (as it was on the old animeworld.yml), but is this okay or should this be mapped to "Movies"?
Thanks