Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update animeworld.cx to new source #11852

Merged
merged 7 commits into from Jun 1, 2021
Merged

Update animeworld.cx to new source #11852

merged 7 commits into from Jun 1, 2021

Conversation

Pfuenzle
Copy link

@Pfuenzle Pfuenzle commented Jun 1, 2021

animeworld.cx changed their source to unit3d, with this commit the jackett integration is working again.

They also had ast4u as their old trackername, but i removed those references as they now require a new registration and old accounts are not working anymore

I have one question though, they have a categorie for Anime Movies, which I mapped to "TV/Anime" (as it was on the old animeworld.yml), but is this okay or should this be mapped to "Movies"?

Thanks

@garfield69
Copy link
Contributor

they have a categorie for Anime Movies, which I mapped to "TV/Anime" (as it was on the old animeworld.yml), but is this okay

It's quite acceptable since torznab does not have a movies/anime category.

@garfield69
Copy link
Contributor

Don't forget to update the readme.md and amend the current AnimeWorld (AST4u) entry.

Pfuenzle and others added 2 commits June 1, 2021 21:34
Co-authored-by: garfield69 <garfieldsixtynine@gmail.com>
@Pfuenzle
Copy link
Author

Pfuenzle commented Jun 1, 2021

Alright, I merged the music and book search from your review and removed the reference to ast4u from the readme. Thanks for looing over this :)

I hope its fine now

Copy link
Contributor

@garfield69 garfield69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garfield69
Copy link
Contributor

@ilike2burnthing feel like I've forgotten something...

Copy link
Contributor

@ilike2burnthing ilike2burnthing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I think recent changes have been to set anime movies as Movies\Other:

# Anime as Movies (Radarr uses t=movie):
- {id: 1_0, cat: Movies/Other, desc: "Anime"}
- {id: 1_1, cat: Movies/Other, desc: "Anime music videos"}
- {id: 1_2, cat: Movies/Other, desc: "English subtitled animes"}
- {id: 1_3, cat: Movies/Other, desc: "Non-english subtitled animes"}
- {id: 1_4, cat: Movies/Other, desc: "Raw animes"}

See also dmhy.

Where the quality is part of the category name (e.g. SD, HD, BluRay, etc.) then Movies\SD, Movies\HD, Movies\BluRay, etc. are used; see U2 and AnimeTorrents.

src/Jackett.Common/Definitions/animeworld.yml Outdated Show resolved Hide resolved
Pfuenzle and others added 2 commits June 2, 2021 00:39
Co-authored-by: ilike2burnthing <59480337+ilike2burnthing@users.noreply.github.com>
Co-authored-by: ilike2burnthing <59480337+ilike2burnthing@users.noreply.github.com>
@Pfuenzle
Copy link
Author

Pfuenzle commented Jun 1, 2021

They only have one category for anime movies and movies in general, so I think movies/others is also a good mapping

@ilike2burnthing ilike2burnthing merged commit 87dacde into Jackett:master Jun 1, 2021
@Pfuenzle Pfuenzle deleted the patch-1 branch June 1, 2021 23:25
@garfield69
Copy link
Contributor

v0.18.225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants