unit3d: move api key auth in headers #14429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe in the future... |
|
No issue with this, we already use API key headers for PolishTracker and Milkie. |
|
I'll revise in the future. 👍 |
mynameisbogdan
force-pushed
the
unit3d-tokens
branch
from
ab6e67a
to
9f25023
Compare
mynameisbogdan
force-pushed
the
unit3d-tokens
branch
from
9f25023
to
e8dc35f
Compare
mynameisbogdan
force-pushed
the
unit3d-tokens
branch
from
e8dc35f
to
babe693
Compare
ilike2burnthing
approved these changes
Jun 6, 2023
|
Since you merged this PR, HD-Olimpo (API) - https://hd-olimpo.club/ began to fails it's uses unit3d too |
|
Thanks, fixed in dcec234. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving the api keys to headers, thus making the URLs with credentials another thing not to worry about.