Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTTime]: increase requestDelay #15287

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented May 1, 2024

Description

PTTime increased its rate limie, so we need increase requestDelay.

it raised a System.Exception: Remote server returned TooManyRequests in logs with current config.

Copy link
Contributor

@garfield69 garfield69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there is now a seeding requirement, then you also need to provide a minimumseedtime or/and a minimumratio, so that users know how long torrents must be kept seeding after download and/or to what ratio to avoid a hit&run penalty.
examples:

    # [OPTIONAL] minimum ratio the torrent client must seed to avoid Hit & Run penalties
    minimumratio:
      text: 1.0
    # [OPTIONAL] minimum number of seconds the client must seed to release the MR requirement
    minimumseedtime:
      # 1 day (as seconds = 24 x 60 x 60)
      text: 86400

@trim21
Copy link
Contributor Author

trim21 commented May 1, 2024

if there is now a seeding requirement, then you also need to provide a minimumseedtime or/and a minimumratio, so that users know how long torrents must be kept seeding after download and/or to what ratio to avoid a hit&run penalty. examples:

    # [OPTIONAL] minimum ratio the torrent client must seed to avoid Hit & Run penalties
    minimumratio:
      text: 1.0
    # [OPTIONAL] minimum number of seconds the client must seed to release the MR requirement
    minimumseedtime:
      # 1 day (as seconds = 24 x 60 x 60)
      text: 86400

Sorry, I misunderstand what ratioless means. It has a global ratio requirement but not per-torrent ratio requirement. I just revert description part.

@trim21 trim21 changed the title Update description for PTTime and increase requestDelay [PTTime]: increase requestDelay May 1, 2024
@ilike2burnthing
Copy link
Contributor

So I can see the announcement from today about crawlers and third-party programs. While it's not banning them, it is warning about their misuse and the pressures they can put on the site. I can't see anything about a specific limit, but 10s is a hell of a jump. I've run about a dozen different searches with the tracker from Jackett, all about 3-4s apart, and got no errors.

I had a look at the announcements, forum, and rules, but can't see anything specific about a required delay. However, I'm using Google Translate for all this, so I'm not sure how accurate it is.

Is there anything specific, or were you just being cautious? If the latter, I'd prefer something more reasonable, like 5s.

@trim21
Copy link
Contributor Author

trim21 commented May 1, 2024

So I can see the announcement from today about crawlers and third-party programs. While it's not banning them, it is warning about their misuse and the pressures they can put on the site. I can't see anything about a specific limit, but 10s is a hell of a jump. I've run about a dozen different searches with the tracker from Jackett, all about 3-4s apart, and got no errors.

I had a look at the announcements, forum, and rules, but can't see anything specific about a required delay. However, I'm using Google Translate for all this, so I'm not sure how accurate it is.

Is there anything specific, or were you just being cautious? If the latter, I'd prefer something more reasonable, like 5s.

can you visit pttime? it's here

It's actually updated at 2023-03-12 08:44, not tody. and code is updated 2 years ago.

And you are right, I just tested, 5s won't trigger TooManyRequests error. so 5s maybe?

@ilike2burnthing
Copy link
Contributor

Yea, that's what I was looking at in the rules.

The announcement is on the homepage, and was made today.

Yea, change to 5s and I'll merge. Thanks.

@trim21
Copy link
Contributor Author

trim21 commented May 1, 2024

actually I didn't see that announcement 😂

@ilike2burnthing ilike2burnthing merged commit 5d451b1 into Jackett:master May 1, 2024
3 of 14 checks passed
@trim21 trim21 deleted the pttime branch May 1, 2024 19:50
@garfield69
Copy link
Contributor

v0.21.2526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants