-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: refactor http webclient part 17 #8529 #9589
Conversation
@garfield69 @ilike2burnthing This is working. The only concern is I'm printing the binary responses too (eg .torrent files) because it's really hard to know if the content is binary or plain text. In my Linux this is working fine. Could you try this PR in Windows downloading a .torrent in debug mode? I tried with yourbittorrent indexer. |
Wait |
Yea, working in Windows. Only side effect is:
|
Print HTML in debug mode. Fix bugs in old implementation too
5f6f45d
to
644fcfa
Compare
Fixed. Do some tests and merge. |
Works here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic improvement to the debug html dump
at last I get to see output from the post to a thankyou before download!
tested on win10home.
Print HTML in debug mode. Fix bugs in old implementation too