-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Torrent-Syndikat indexer to new API #9732
Conversation
50ae1da
to
5c13f74
Compare
Sorry for the conflict, seems like I forgot to pull upstream. My bad! Should work now. |
Hum, I never head about that. Is a hackathon or something like that? You mean adding Jackett to the "list of projects to work on" so other developers can fix open issues for us? |
5c13f74
to
707256d
Compare
707256d
to
0f27d3d
Compare
0f27d3d
to
d70af76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good for me but I can't test it. Do these tests for me:
- Empty search
- Search "harry"
- Search "sdadadadadasd112321"
- Empty search with category
- IMDB search (with a valid ID and with invalid id)
Displays the latest 50 torrents, all fine. 0m ago, 2m ago, 3m ago etc., as expected.
Displays 50 torrents with "harry" in the title, including some Harry Potter movies as one would expect.
Manual search for "sdadadadadasd112321" on torrentsyndikat with 0 results.
Empty search with "5040" returns the 50 latest torrents of "TV/HD", as expected.
Valid ID, no torrents: 0 torrents, as expected |
Thanks for the review & merge!
Yes, basically. Every October DigitalOcean calls for participation in Open Source projects on GitHub – the Hacktoberfest. They reward participation by sending out T-Shirts and merchandise/stickers for at least 4 valid Pull Requests for the first 70000 participants that reach that goal. Normally every PR to any repo would count (after a random sampling) but this year there was some spam – people made PRs with meaningless changes to README files, stuff like that. Maintainers can tag invalid PRs as |
@hashworks @garfield69 @ilike2burnthing All PRs in this repository qualify to Hacktoberfest. Good luck! |
Resolves #9543.
Could we add a
hacktoberfest
repo topic?