Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Torrent-Syndikat indexer to new API #9732

Merged
merged 2 commits into from
Oct 4, 2020

Conversation

hashworks
Copy link
Contributor

Resolves #9543.

Could we add a hacktoberfest repo topic?

@hashworks
Copy link
Contributor Author

Sorry for the conflict, seems like I forgot to pull upstream. My bad! Should work now.

src/Jackett.Common/Indexers/TorrentSyndikat.cs Outdated Show resolved Hide resolved
src/Jackett.Common/Indexers/TorrentSyndikat.cs Outdated Show resolved Hide resolved
src/Jackett.Common/Indexers/TorrentSyndikat.cs Outdated Show resolved Hide resolved
src/Jackett.Common/Indexers/TorrentSyndikat.cs Outdated Show resolved Hide resolved
@ngosang
Copy link
Member

ngosang commented Oct 4, 2020

Could we add a hacktoberfest repo topic?

Hum, I never head about that. Is a hackathon or something like that? You mean adding Jackett to the "list of projects to work on" so other developers can fix open issues for us?
Any PR is welcome, we have a lot of open issues that are easy to work on.

@garfield69

Copy link
Member

@ngosang ngosang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good for me but I can't test it. Do these tests for me:

  • Empty search
  • Search "harry"
  • Search "sdadadadadasd112321"
  • Empty search with category
  • IMDB search (with a valid ID and with invalid id)

@hashworks
Copy link
Contributor Author

hashworks commented Oct 4, 2020

Code looks good for me but I can't test it. Do these tests for me:

  • Empty search

Displays the latest 50 torrents, all fine. 0m ago, 2m ago, 3m ago etc., as expected.

  • Search "harry"

Displays 50 torrents with "harry" in the title, including some Harry Potter movies as one would expect.

  • Search "sdadadadadasd112321"

Manual search for "sdadadadadasd112321" on torrentsyndikat with 0 results.

  • Empty search with category

Empty search with "5040" returns the 50 latest torrents of "TV/HD", as expected.

  • IMDB search (with a valid ID and with invalid id)

Valid ID, no torrents: 0 torrents, as expected
Invalid ID (404 on IMDB): 0 torrents, as expected
Valid ID (Avatar): 14 torrents, the exact number of torrents we have for this movie

@ngosang ngosang merged commit 84e0dde into Jackett:master Oct 4, 2020
@hashworks
Copy link
Contributor Author

Thanks for the review & merge!

Hum, I never head about that. Is a hackathon or something like that? You mean adding Jackett to the "list of projects to work on" so other developers can fix open issues for us?

Yes, basically. Every October DigitalOcean calls for participation in Open Source projects on GitHub – the Hacktoberfest. They reward participation by sending out T-Shirts and merchandise/stickers for at least 4 valid Pull Requests for the first 70000 participants that reach that goal. Normally every PR to any repo would count (after a random sampling) but this year there was some spam – people made PRs with meaningless changes to README files, stuff like that. Maintainers can tag invalid PRs as spam or invalid, but you A) have to know that and B) might not want to deal with it at all. Therefore, it is now required to add the hacktoberfest tag to participating repositories.

https://hacktoberfest.digitalocean.com/

@ngosang
Copy link
Member

ngosang commented Oct 5, 2020

@hashworks @garfield69 @ilike2burnthing All PRs in this repository qualify to Hacktoberfest. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] Torrent-Syndikat switching to using API
2 participants