Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darmowetorrenty: migrate indexer to C# resolves #9782 #9808

Merged
merged 15 commits into from Oct 12, 2020
Merged

darmowetorrenty: migrate indexer to C# resolves #9782 #9808

merged 15 commits into from Oct 12, 2020

Conversation

ertugrulk
Copy link
Contributor

Rewrote darmowetorrenty indexer in C# based on the YAML file. Fixes issue #9782

@jackettbot
Copy link

jackettbot bot commented Oct 11, 2020

Hi @ertugrulk,

Thanks for your contribution to Jackett!

If you are adding a new indexer, please ensure that you've added it to the readme as well

A human will be along soon to review

ertugrulk and others added 7 commits October 11, 2020 12:37
ratioless and without H&R
id=darmowetorenty
seeders and leechers can be missing, supply 0
correct details link missing
if size is missing default 0 bytes
@garfield69 garfield69 changed the title Rewrote darmowetorrenty indexer in C# darmowetorrenty: migrate indexer to C# resolves #9782 Oct 11, 2020
{"erotyka", "1"}
};
searchUrl += "?" + queryCollection.GetQueryString();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nearly done ;-)

search for Dziewiąta Devyataya yields no result with indexer but returns results on web site
url generated by:
indexer: https://darmowe-torenty.pl/torrenty.php?search=Dziewi%C4%85ta+Devyataya&category=0&erotyka=1
web site: https://darmowe-torenty.pl/torrenty.php?search=Dziewi%B1ta+Devyataya&category=0&erotyka=1

something to do with how the indexer is managing diacritics?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, fixed by generating the query string using the site's preferred encoding.

Copy link
Contributor

@garfield69 garfield69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
tested on dashboard

@garfield69 garfield69 merged commit fed43f9 into Jackett:master Oct 12, 2020
@garfield69
Copy link
Contributor

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants