Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addListener does not check for duplication #48

Closed
uwydoc opened this issue Mar 27, 2014 · 3 comments
Closed

addListener does not check for duplication #48

uwydoc opened this issue Mar 27, 2014 · 3 comments

Comments

@uwydoc
Copy link

uwydoc commented Mar 27, 2014

If one callback is bound to one event multiple times, multiple instances of the callback would be stored, and unbind would only remove only one instance instead of all, which is not what the api describes.
It should be fixed ASAP.

JacksonTian added a commit that referenced this issue Mar 27, 2014
@JacksonTian
Copy link
Owner

callback can be bound to on event multiple time. I fixed the unbind issue.

@uwydoc
Copy link
Author

uwydoc commented Mar 27, 2014

so quick. 👍 i had thought to push and submit a merge request later today(hesitated cause only one line of code). never mind.

@JacksonTian
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants