Renamed Jupyter Notebook Doctype and Format
#3832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BilalM04
requested review from
JacquesCarette,
smiths,
samm82,
bmaclach and
cd155
as code owners
|
Yes to changing the space to an underscore. |
JacquesCarette
previously approved these changes
Jul 4, 2024
samm82
approved these changes
Jul 5, 2024
JacquesCarette
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3830
Changes
JupytertoLessoninDoctype.JSONtoJupyterinFormat.build/example-name/Jupyterdirectory tobuild/example-name/Lesson.build/example-name/SRS/JSONdirectory tobuild/example-name/SRS/Jupyter.I also noticed the generated Jupyter Notebook lessons (currently only for projectile), generates with the name
Projectile Lesson.ipynb. From experience, file paths with spaces cause a lot of inconveniences. Should I change this toProjectile_Lesson.ipynb?