TECH-1808 Refactor Load Average #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkevan
previously approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Looks good to me, I'm just worried about the ThreadLoadAverage that was not enabled in Jahia core originally.
Not sure if we should re-implement it here or also disable it.
I dont want the probe to return bad status because of the thread load average badly calibrated
…fore full migration to SAM module)
…ation for future SAM evolution
…fore full migration to SAM module)
jkevan
approved these changes
Jun 11, 2024
|
Replaced by #135 because github side rebase has not signed commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://jira.jahia.org/browse/TECH-1808
Description
Integrate LoadAverage generation
Modify GraphQL references to local metrics instead of core.
Tests
The following are included in this PR
Checklist
I have considered the following implications of my change:
Documentation