Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant branch name #18

Closed
wants to merge 9 commits into from

Conversation

dword-design
Copy link
Contributor

I think it makes more sense to use a constant branch + PR and update it. This way we do not have multiple PRs in case the metadata change more often.

We need to have these PRs fixed for this:

@Jaid
Copy link
Owner

Jaid commented May 24, 2021

I am not quite sure if this change could lead to unexpected consequences, but I'm gladly willing to try.

commitManager.options.branch is now available in commit-from-action v2.

Jaid added a commit that referenced this pull request May 24, 2021
…on integration, following #18

Signed-off-by: Jaid <jaid.jsx@gmail.com>
@Jaid
Copy link
Owner

Jaid commented May 24, 2021

I'll add the user's choice between a constant branch name and a randomly generated branch name later this day.

@Jaid
Copy link
Owner

Jaid commented May 25, 2021

New change based on this pull request:

Constant branch name is the new default now.

- name: Jaid/action-sync-node-meta
  uses: jaid/action-sync-node-meta@v2.0.0
  with:
    githubToken: ${{ secrets.GITHUB_TOKEN }}
    branch: action-sync-node-meta

Random addition is optional.

- name: Jaid/action-sync-node-meta
  uses: jaid/action-sync-node-meta@v2.0.0
  with:
    githubToken: ${{ secrets.GITHUB_TOKEN }}
    branch: action-sync-node-meta_{random}

@dword-design
Copy link
Contributor Author

@Jaid even better

@dword-design dword-design deleted the constant-branch-name branch May 27, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants