-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for reading custom cert paths #104
Add support for reading custom cert paths #104
Conversation
I assume these variables are commonly set by those who use custom certs? If it is I guess this is fine, but personally I find them quite confusing since lib/curl nor requests (I guess python?) is used in any way by this library. |
Yes. To my knowledge, https://stackoverflow.com/questions/42982143/python-requests-how-to-use-system-ca-certificates-debian-ubuntu I guess we can also use https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set_default_verify_paths.html |
I guess as long as they are documented it doesn't really matter |
@@ -16,7 +16,7 @@ default = ["rustls-tls"] | |||
rustls-tls = ["ureq/tls"] | |||
# If this feature is enabled we instead use the native TLS implementation for the | |||
# target platform | |||
native-tls = ["ureq/native-tls", "native-tls-crate/vendored"] | |||
native-tls = ["ureq/native-tls", "native-tls-crate/vendored", "rustls-pemfile", "rustls"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe rustls
isn't required here, only rustls-pemfile
is needed.
Fixes #103
As per discussed in #103 , this PR adds support to use custom ca cert via setting the env variable
REQUESTS_CA_BUNDLE
orCURL_CA_BUNDLE
that points to the custom cert file