Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users with no skin but with cape get wrong avatar #44

Closed
jomo opened this issue Dec 13, 2014 · 11 comments
Closed

Users with no skin but with cape get wrong avatar #44

jomo opened this issue Dec 13, 2014 · 11 comments
Labels
bug Mojang Issues related to Mojang/Minecraft and their APIs

Comments

@jomo
Copy link
Contributor

jomo commented Dec 13, 2014

Some affected users

All users with a cape and without a skin, e.g.:

Edit: removed list
(all users with no skin)

Spoiler alert

They all redirect to http://textures.minecraft.net/texture/8adb45dbefe2465745a6d1fcee9b8a721792e21c5eb1524ef516bb6fb189 (which is their cape, not their skin)
Usually http://skins.minecraft.net/MinecraftSkins/<name>.png redirects to the skin.


This is 100% Mojang's error, and I can (probably) tell what's causing it without seeing their code:
Mojang seems to store textures as JSON like this:

"textures": {
  "SKIN": {
    "url": "http://textures.minecraft.net/texture/foo"
  },
  "CAPE": {
    "url": "http://textures.minecraft.net/texture/bar"
  }
}

The skin seems to always come first, so I'm quite sure Mojang redirects to textures[0]. Of course that is wrongfully the cape URL if the user has no skin.


Sorry for all the mentions below, not sure who's responsible for this kind of stuff.
Perhaps @Dinnerbone, @KrisJelbring or @grum could look into this? This is definitely a bug on your side ;)

@jomo jomo added the bug label Dec 13, 2014
@jomo
Copy link
Contributor Author

jomo commented Dec 13, 2014

Here is the image it redirects to:
cape
For some reason it's application/octet-stream instead of image/png, anyway, the resulting avatar is obviously messed up:
messed up avatar

@jomo
Copy link
Contributor Author

jomo commented Dec 13, 2014

See also WEB-14.

@jengel3
Copy link
Contributor

jengel3 commented Dec 13, 2014

Interesting that this likely wouldn't have been discovered without the Scrolls capes..

@ezfe
Copy link

ezfe commented Dec 13, 2014

This is an issue strictly with the scrolls capes, not in general. A player without a skin who has a cape won't experience this.

An example is http://skins.minecraft.net/MinecraftSkins/ezekielelin.png (minecon cape, no skin)

2014-12-13_14 46 35

@jomo
Copy link
Contributor Author

jomo commented Dec 13, 2014

I'm not sure what you're trying to say @ezfe. Do you mean players are not affected by this ingame?
It's a bug in the API.

@jomo
Copy link
Contributor Author

jomo commented Dec 13, 2014

Thanks for your edit, confirmed.

@jomo jomo closed this as completed Dec 13, 2014
@ezfe
Copy link

ezfe commented Dec 13, 2014

@jomo No, I'm saying the issue is just with the scrolls capes. Not sure if your second post indicates you got that.

@jomo
Copy link
Contributor Author

jomo commented Dec 13, 2014

Yep I got that :)

@tomassommar
Copy link

Yes, this was a bug affecting the legacy skins system during the Scrolls cape campaign, and thus affecting users using older Minecraft versions.

Good catch, and very well reported! The bug has been fixed, even though it is technically not since the celebration is no longer active, to avoid the same issue in the future with possible upcoming events, if any.

@jomo
Copy link
Contributor Author

jomo commented Dec 15, 2014

Thanks Tomas, WEB-14 is still open. I'm not able to close it :/

@jengel3
Copy link
Contributor

jengel3 commented Dec 15, 2014

Thanks!

@jomo jomo added the Mojang Issues related to Mojang/Minecraft and their APIs label May 24, 2015
@jomo jomo changed the title [MOJANG] Users with no skin but with cape get wrong avatar Users with no skin but with cape get wrong avatar May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Mojang Issues related to Mojang/Minecraft and their APIs
Projects
None yet
Development

No branches or pull requests

4 participants