Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to save params. #4

Closed
JakeCarter opened this issue Jun 2, 2019 · 3 comments
Closed

Add ability to save params. #4

JakeCarter opened this issue Jun 2, 2019 · 3 comments
Assignees
@JakeCarter
Labels
enhancement New feature or request

Comments

@JakeCarter
Copy link
Owner

No description provided.

@JakeCarter JakeCarter self-assigned this Jun 2, 2019
@JakeCarter
Copy link
Owner Author

While working on crow support, I setup the params to conditionally hide params that didn't make sense with certain settings. (For instance, I hide the filter cutoff if output is set to crow.) This makes saving/loading params very difficult.

First thing to do to get params to save is to list all params, even inactive ones.

@JakeCarter JakeCarter added the enhancement New feature or request label Nov 3, 2019
JakeCarter pushed a commit that referenced this issue Nov 3, 2019
Saving and Loading Params Support
f6fd8e0 
Removed conditional hiding/showing of irrelevant params.
Fixed collision with `beatclock`'s 'clock' param.

Circles now supports the system saving/loading of params. See the PARAMETERS section of https://monome.org/docs/norns/ for more information.

Issue: #4
@JakeCarter
Copy link
Owner Author

In the long run I'd like to support param menus (monome/norns#491) but for now I'm just going to support standard param saving/loading. I'll file a new issue to support the submenus.

To support basic saving/loading:

  • Remove conditional hiding/showing of irrelevant params.
  • Fix collision with beatclock's 'clock' param.

JakeCarter pushed a commit that referenced this issue Nov 3, 2019
Release checklist.
05a7eb3 
Bumped version number.
Added release notes.

Issue: #4
@JakeCarter
Copy link
Owner Author

Merged to master in f085302

@JakeCarter JakeCarter mentioned this issue Nov 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JakeCarter JakeCarter

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JakeCarter