Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework (v3) #71

Open
wants to merge 296 commits into
base: master
Choose a base branch
from
Open

Rework (v3) #71

wants to merge 296 commits into from

Conversation

JakeSidSmith
Copy link
Owner

@JakeSidSmith JakeSidSmith commented Sep 11, 2016

Before alpha release (3.0.0-alpha.0)

  • Adjust how components are passed in (as children)
  • Update readme
  • Support for ImmutableJS (call toArray on Immutable Lists)
  • Callback only supplies previous & next indices
  • Callback supplies additional boolean as to whether the item was dropped on another item
    (or between them)
  • Add helper methods for reordering
  • Auto-scroll while dragging
  • Allow defining the tag to use for the wrapper
  • Use JSX in examples
  • Fix React 15: "This synthetic event is reused for performance reasons" on mobile
  • Continuous integration (CircleCI)
  • Optional autoScroll
  • Optional autoScrollParents
  • Optional autoScrollWindow
  • Disable reordering certain components with data-reorder-disabled prop
  • Allow programatic disabling of drag and drop for a list (Allows blocking drag and/or drop requests programatically #70)
  • onReorderStart callback (Feat/add onDragStart prop #85)
  • Abstraction for merging custom props with injected reorder props (when supplying a SFC or class)
  • Do not begin reordering if reorder is in progress (allows nesting reorder components)
  • Additional examples
  • Tests (Mocha)
  • 100% coverage
  • Setup CI
  • Update readme again
  • Mention draggable={false} to prevent image dragging
  • Placeholder class correctly applied. Fixes placeholder class is not added when dragging input fields #76
  • Test in React 0.13, 0.14 and 15

Next

  • Support dragging between lists
  • Callback supplies list IDs where necessary

Soon (Possibly)

  • Support multi-select / drag

@HriBB
Copy link
Contributor

HriBB commented Nov 18, 2016

@JakeSidSmith is there anything we can do to help you out? Maybe create some examples? I'm using version 2.1.0 and it works great on desktop, but has problems on mobile, so I'm looking forward to this PR.

@JakeSidSmith
Copy link
Owner Author

@HriBB I've been pretty busy, but feel free to fork from this branch & contribute. When you're happy, open a PR against this branch. :)

Was going to sort out the auto-scrolling next, but have to make sure this is accounted for. You can have a go at that if you like?

One thing to bare in mind, I'm changing the auto-scroll area bounds a little. They should be 33.33% of the width / height... but no larger than 20px or so (have not decided on an exact value yet). This way there's a 33.33% dead zone in the center, but shouldn't take up so much room on large containers.

Got a start & watch script for the examples (where I've been testing stuff).

npm start
npm run watch

@tmm1
Copy link

tmm1 commented Apr 6, 2018

Would love to see this PR merged and 3.0 to become an official non-alpha release.

@JakeSidSmith
Copy link
Owner Author

@tmm1 as would I. There's just a few issues / improvement to add (tracked here). Hard to find the time to address these, but v3 is in a much better state than v2, so I'd recommend moving to the alpha anyway. 🙂

@tmm1
Copy link

tmm1 commented Apr 8, 2018

I have already switched, and agree that the api is much better and that v3 works much better. Thus I would recommend merging this PR and releasing 3.0.0, and then addressing the remaining items in follow up releases.

@tmm1
Copy link

tmm1 commented Apr 8, 2018

Alternatively do a beta release, because "alpha" does not do justice to how well v3 works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants