Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: This synthetic event is reused for performance reasons. #75

Closed
HriBB opened this issue Nov 3, 2016 · 3 comments
Closed

Warning: This synthetic event is reused for performance reasons. #75

HriBB opened this issue Nov 3, 2016 · 3 comments

Comments

@HriBB
Copy link
Contributor

HriBB commented Nov 3, 2016

Hey

I'm seeing this warning on "mobile", via chrome developer tools.

Warning: This synthetic event is reused for performance reasons.
If you're seeing this, you're adding a new property in the synthetic event object.
The property is never released.

See https://fb.me/react-event-pooling for more information.

In handleTouchEvents you're adding clientX and clientY to the event object, which I guess is bad in React.

itemDown: function (item, index, event) {
  this.handleTouchEvents(event);
  ...
}

handleTouchEvents: function (event) {
  if (event.touches && event.touches.length) {
    event.clientX = event.touches[0].clientX;
    event.clientY = event.touches[0].clientY;
  }
},

Maybe you can include that in the rewrite? Otherwise I can take a look and make a PR.

@HriBB
Copy link
Contributor Author

HriBB commented Nov 3, 2016

Ohh and I just realized that I cannot tap on IconButton in the list.

@JakeSidSmith
Copy link
Owner

Hey, @HriBB going through a big re-write at the moment in which this is already fixed. :)

#71

@HriBB
Copy link
Contributor Author

HriBB commented Nov 12, 2016

@JakeSidSmith I thought so, just wanted to make sure this is fixed. Closing.

@HriBB HriBB closed this as completed Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants