Fix declarations of aligned allocators. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like you might need a `const` for the first argument of `std::pair` in `aligned_allocator`, see JakobEngel#111. Added some `override` statements to Output3DWrapper's derived classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111. It seems like you need a
constfor the first argument of astd::pairinaligned_allocatorto make xcode 9 happy.Fix the override of
PangolinDSOViewer::publishGraph. Without this patch, the display of constraints does not work as it used to.Added some
overridestatements to Output3DWrapper's derived classes, to avoid such problems in the future.